[Libva] "va/va_trace.c" patch for review

Yuan, Shengquan shengquan.yuan at gmail.com
Thu Jun 9 01:19:03 PDT 2011


On Thu, Jun 9, 2011 at 3:50 PM, Osin, Alexander I
<alexander.i.osin at intel.com> wrote:
>        Hi,
>        May I suggest simple patch of "va/va_trace.c", please?
>
> There are:
> a)      Added prints for new fields of h.264 structures.
> b)      Corrected print format for some h.264 values.
> c)      Added print for new field of VC1 structure.
> d)      Added "fflush" in key points of trace functions (overhead is min). It would help to localize hangs in libva.
> e)      Replaced '\t' from C-source code by '     ' spaces.
> f)      Updated Copyright from 2009 to 2009-2011.
>
-    va_TraceMsg(idx, "\tfield_pic_flag = %d\n",
p->pic_fields.bits.field_pic_flag);
-    va_TraceMsg(idx, "\tconstrained_intra_pred_flag = %d\n",
p->pic_fields.bits.constrained_intra_pred_flag);
+    va_TraceMsg(idx, "\tpic_fields = 0x%03x\n", p->pic_fields.value);
+    va_TraceFlagIfNotZero(idx, "\t\tentropy_coding_mode_flag",
p->pic_fields.bits.entropy_coding_mode_flag);
+    va_TraceFlagIfNotZero(idx, "\t\tweighted_pred_flag",
p->pic_fields.bits.weighted_pred_flag);
+    va_TraceFlagIfNotZero(idx, "\t\tweighted_bipred_idc",
p->pic_fields.bits.weighted_bipred_idc);
+    va_TraceFlagIfNotZero(idx, "\t\ttransform_8x8_mode_flag",
p->pic_fields.bits.transform_8x8_mode_flag);

These fields will not be printed if the value is zero?
We need them to be printed if we want to compare the trace  of player
A and player B.

Thanks
-Austin


More information about the Libva mailing list