[Libva] Suggestion: libva debug print patches

[Osin, Alexander I]

	Hi,
	I recovered 'libva' debug print functionality. Also I implemented i965_LockSurface/i965_UnlockSurface associated functionality. My changes don't affect "va.h" and didn't change existing functionality. They recovered absent (old) functionality only. Could I share my patches with you, please? 

	Details. My patch affects 5 files.

a) "i965_drv_video" functionality:
	1) 0001-Implemented-i965_LockSurface-i965_UnlockSurface-i965.patch
	"i965_drv_video/i965_drv_video.c" -Implemented i965_BufferInfo, i965_LockSurface (w/o synchronization), i965_UnlockSurface (w/o synchronization). Added " object_surface.locked_image_id" initialization. (+ replaced rare \t by spaces.)
	2) 0002-Added-locked_image_id-in-struct-object_surface.patch
	"i965_drv_video/i965_drv_video.h" -Added "locked_image_id" field in 'object_surface' internal structure. It is needed for correct 'ImageID' pass between i965_LockSurface and i965_UnlockSurface.

b) "va" functionality:
	1) 0003-Fixed-number-bugs-in-va_TraceSurface.patch
	"va/va_trace.c" -Fixed some critical bugs for correct debug print functionality.
	2) 0004-corrected-vaBufferInfo-interface.patch
	"va/va.c" Corrected ctx->vtable->vaBufferInfo() INTERNAL interface.
	3) 0005-corrected-vaBufferInfo-interface.patch
	"va/va_backend.h" Corrected ctx->vtable->vaBufferInfo() INTERNAL interface.

	I didn't correct YUV output prints. There is quite simple implementation in vaTrace. IMHO, it could be wrong for some cases.

Thank you,
Alexander

P.S.
BTW, debug prints are switched in '/etc/libva.conf' file or in environment by 4 defined (details are in libva's readme).
I sent my proposals last week. My e-mail was banned because I was outside 'libva' group. I have recent it again.

-----Original Message-----
From: Xiang, Haihao 
Sent: Wednesday, April 27, 2011 6:24 AM
To: Osin, Alexander I
Subject: Re: LockSurface/UnlockSurface/libvaPrint patch

On Wed, 2011-04-27 at 00:25 +0800, Osin, Alexander I wrote:
> 	Haihao,
> 	I attached my patch for 'master' branch. Please, could you review it? 'Libva' debug print works fine now.

[skip]
The fix for i965 driver is ok for me.
[skip]
BTW Could you send your patches to libva mail list, maybe some others are interested in your fixes about VA.

Thanks
Haihao


--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park, 
17 Krylatskaya Str., Bldg 4, Moscow 121614, 
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implemented-i965_LockSurface-i965_UnlockSurface-i965.patch
Type: application/octet-stream
Size: 9500 bytes
Desc: 0001-Implemented-i965_LockSurface-i965_UnlockSurface-i965.patch
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110504/ba1d5368/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Added-locked_image_id-in-struct-object_surface.patch
Type: application/octet-stream
Size: 754 bytes
Desc: 0002-Added-locked_image_id-in-struct-object_surface.patch
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110504/ba1d5368/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fixed-number-bugs-in-va_TraceSurface.patch
Type: application/octet-stream
Size: 2059 bytes
Desc: 0003-Fixed-number-bugs-in-va_TraceSurface.patch
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110504/ba1d5368/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-corrected-vaBufferInfo-interface.patch
Type: application/octet-stream
Size: 677 bytes
Desc: 0004-corrected-vaBufferInfo-interface.patch
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110504/ba1d5368/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-corrected-vaBufferInfo-interface.patch
Type: application/octet-stream
Size: 1104 bytes
Desc: 0005-corrected-vaBufferInfo-interface.patch
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110504/ba1d5368/attachment-0004.obj>