[Libva] Fwd: FGLRX detection code overly restrictive

Stephan Diestelhorst stephan.diestelhorst at gmail.com
Tue Oct 11 03:03:57 PDT 2011


On Tue, Oct 11, 2011 at 11:50 AM, Gwenole Beauchesne <gb.devel at gmail.com> wrote:
> Hi,
>
> 2011/10/11 Stephan Diestelhorst <stephan.diestelhorst at gmail.com>:
>> On Tue, Oct 11, 2011 at 11:21 AM, Gwenole Beauchesne <gb.devel at gmail.com> wrote:
>
>>>> Thanks for the patch. I will have a look at it tomorrow. The success =
>>>> (*driver_name != NULL) is definitely the right option. I might fix the
>>>> display problem differently though, depending on how much information
>>>> ADL can provide.
>>>
>>> I pushed a fix to git master. Please test.
>>
>> Works, great!
>>
>> Manual inspection shows however, that your code also would tolerate different
>> screens than ".0" to be equal to the omitted one, which is different from my
>> patch.
>
> The screen number was already checked numerically. i.e. it was provided by ADL.

That makes sense, then.

Stephan


More information about the Libva mailing list