[Libva] [PATCH 2/4] libva: fix for Android ICS

[Huang, Haitao]

On Tue, Aug 21, 2012 at 8:20 AM, Huang, Haitao <haitao.huang at intel.com> wrote:
> On Tue, Aug 21, 2012 at 8:06 AM, Huang, Haitao <haitao.huang at intel.com> wrote:
>> On Mon, Aug 20, 2012 at 4:46 PM, Gwenole Beauchesne <gb.devel at gmail.com> wrote:
>>> Hi,
>>>
>>> 2012/8/20 Haitao Huang <haitao.huang at intel.com>:
>>>> This fixes existing tests for Android ICS build.
>>>> updated headers exported for new drm changes
>>>> Removed dependencies on deprecated Android APIs.
>>>> Added LIBVA_VERSION_S defines.
>>>> Removed unsupported encoder test
>>>
>>> Could you please look at removing the dependency on
>>> x11/va_dricommon.h? This normally should not be needed anymore. Even
>>> the Bool/True/False definitions could go away.
>>>
>> Sure, I'll check.
>>
> This is still needed to be exported to compile drivers that is
> implementing dri back-end?
> For example, in intel-driver, i965_output_dri.c includes this header.
> We could force drivers to not implement, but that's extra steps and
> probably not necessary?
>

Sorry,  I just saw you removed dependency in driver as well. It's just
our branch is not rebased yet.
I'll remove it from Android.mk and resubmit

>>> LIBVA_VERSION_S ideally needs to be generated like for VA_VERSION_*,
>>> but this is is not essential since this is only valid for tests.
>>>
>> This is only used by vainfo, which will generate the rest of string,
>> here is the output:
>> VA-API version: 0.34 (libva 1.2.0.pre1)
>>
>>> The rest looks good at first sight.
>>>
>>> Thanks,
>>> Gwenole.