[Libva] [PATCH 2/5] API: introduce DRM common utilities and data structures.

[Gwenole Beauchesne]

Hi,

2012/7/5 Xiang, Haihao <haihao.xiang at intel.com>:
> On Thu, 2012-07-05 at 07:24 +0200, Gwenole Beauchesne wrote:
>> 2012/7/5 Xiang, Haihao <haihao.xiang at intel.com>:
>> >> +/** \brief Base DRM state. */
>> >> +struct drm_state {
>> >> +    /** \brief DRM connection descriptor. */
>> >> +    int         fd;
>> >> +    /** \brief DRM connection type. */
>> >> +    int         type;
>> >> +};
>> >
>> > It doesn't make sense to me. Does it mean DRM connection also is based
>> > on DRI1/DRI2 protocols ?
>>
>> No, but a VA_DRM type could be added, or to replace the "dummy" value.
>
> It confused me a bit. This patch adds the following *DRM* connection
> types:

Actually, the initial meaning was to know how the connection was
authenticated. So, we could have instead

/** \brief DRM authentication type. */
enum {
    /** \brief Disconnected. */
    VA_DRM_AUTH_NONE    = 0,
    /** \brief Connected. Authenticated with DRI1 protocol. */
    VA_DRM_AUTH_DRI1    = 1,
    /** \brief Connected. Authenticated with DRI2 protocol. */
    VA_DRM_AUTH_DRI2    = 2,
    /** \brief Connected. Authenticated with some alternate raw protocol. */
    VA_DRM_AUTH_CUSTOM  = 3
};

Or just keep VA_DRM_AUTH_NONE + VA_DRM_AUTH_CUSTOM in
<va/va_drmcommon.h> and VA_DRI* in <va/va_dricommon.h> files.

Regards,
Gwenole.