[Libva] [PATCH 8/8 965 driver] add YUY2 support in i965_GetSurfaceAttributes, fix a small issue

Gwenole Beauchesne gb.devel at gmail.com
Tue Jun 26 00:59:45 PDT 2012


Hi,

2012/6/26 Zhao Halley <halley.zhao at intel.com>:

> @@ -3584,7 +3584,8 @@ i965_GetSurfaceAttributes(
>                     } else if (obj_config->profile == VAProfileNone) {
>                         if (attrib_list[i].value.value.i != VA_FOURCC('N', 'V', '1', '2') &&
>                             attrib_list[i].value.value.i != VA_FOURCC('I', '4', '2', '0') &&
> -                            attrib_list[i].value.value.i != VA_FOURCC('Y', 'V', '1', '2')) {
> +                            attrib_list[i].value.value.i != VA_FOURCC('Y', 'V', '1', '2') &&
> +                            attrib_list[i].value.value.i != VA_FOURCC('Y', 'U', 'Y', '2')) {
>                             attrib_list[i].value.value.i = 0;
>                             attrib_list[i].flags &= ~VA_SURFACE_ATTRIB_SETTABLE;
>                         }

While we are at adding new formats, please define corresponding
VA_FOURCC_* if they don't exist already. They will be propagated to
libva next, with proper comments as to what they actually represent.

BTW, why not use switch/case?

Thanks,
Gwenole.


More information about the Libva mailing list