[Libva] [PATCH 8/8 965 driver] add YUY2 support in i965_GetSurfaceAttributes, fix a small issue

[Xiang, Haihao]

On Wed, 2012-06-27 at 00:49 +0000, Zhao, Halley wrote: 
> > While we are at adding new formats, please define corresponding
> > VA_FOURCC_* if they don't exist already. They will be propagated to
> > libva next, with proper comments as to what they actually represent.
> Ok, I will add it to va.h.
> Should we replace VA_FOURCC('N', 'V', '1', '2') to VA_FOURCC_NV12 in all source file?

I prefer VA_FOURCC(x, x, x, x). It is easy to add new fourcc for
internal using such VA_FOURCC('I', 'M', 'C', '1') which we don't want to
export currently.


> 
> > BTW, why not use switch/case?
> just follow the existing style, I prefer switch/case as well.
> 
> thanks
> 
> > -----Original Message-----
> > From: Gwenole Beauchesne [mailto:gb.devel at gmail.com]
> > Sent: Tuesday, June 26, 2012 4:00 PM
> > To: Zhao, Halley
> > Cc: libva at lists.freedesktop.org
> > Subject: Re: [Libva] [PATCH 8/8 965 driver] add YUY2 support in
> > i965_GetSurfaceAttributes, fix a small issue
> > 
> > Hi,
> > 
> > 2012/6/26 Zhao Halley <halley.zhao at intel.com>:
> > 
> > > @@ -3584,7 +3584,8 @@ i965_GetSurfaceAttributes(
> > >                     } else if (obj_config->profile == VAProfileNone)
> > {
> > >                         if (attrib_list[i].value.value.i !=
> > > VA_FOURCC('N', 'V', '1', '2') &&
> > >                             attrib_list[i].value.value.i !=
> > > VA_FOURCC('I', '4', '2', '0') &&
> > > -                            attrib_list[i].value.value.i !=
> > > VA_FOURCC('Y', 'V', '1', '2')) {
> > > +                            attrib_list[i].value.value.i !=
> > > + VA_FOURCC('Y', 'V', '1', '2') &&
> > > +                            attrib_list[i].value.value.i !=
> > > + VA_FOURCC('Y', 'U', 'Y', '2')) {
> > >                             attrib_list[i].value.value.i = 0;
> > >                             attrib_list[i].flags &=
> > > ~VA_SURFACE_ATTRIB_SETTABLE;
> > >                         }
> > 
> > While we are at adding new formats, please define corresponding
> > VA_FOURCC_* if they don't exist already. They will be propagated to
> > libva next, with proper comments as to what they actually represent.
> > 
> > BTW, why not use switch/case?
> > 
> > Thanks,
> > Gwenole.
> _______________________________________________
> Libva mailing list
> Libva at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libva