[Libva] [PATCH] Parse aspect ratio when using GStreamer codec parsers

[Simon Farnsworth]

On Wednesday 12 September 2012 06:36:50 Gwenole Beauchesne wrote:
> Hi,
> 
> 2012/9/10 Simon Farnsworth <simon.farnsworth at onelan.co.uk>:
> 
> > +            /* Extended aspect ratio */
> > +            else if (adv_hdr->aspect_ratio == 255 )
> > +                gst_vaapi_decoder_set_pixel_aspect_ratio(base_decoder,
> > +                                                         adv_hdr-
>aspect_horiz_size,
> > +                                                         adv_hdr-
>aspect_vert_size);
> 
> This should be aspect_ratio == 15.
> And par_{n,d} should be 1 + aspect_{horiz,vert}_size, according to
> 6.1.14.3.2 to 6.1.14.3.3. i.e. range of the 8-bit value is 1 to 256.
> 
Would you like a new patch for this, an incremental patch against what I've 
already sent, or are you happy to fix this up yourself for upstream?

I don't have a copy of the VC-1 spec, only of H.264 and MPEG-2, hence the 
errors here; the guide I was using said that it was encoded the same way as 
H.264, but with only indexes 1-13 in the table.
-- 
Simon Farnsworth
Software Engineer
ONELAN Ltd
http://www.onelan.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libva/attachments/20120912/f2608877/attachment.pgp>