[Libva] [PATCH v2 4/4] va_android: use common drm driver detection

Gwenole Beauchesne gb.devel at gmail.com
Thu Sep 27 08:52:58 PDT 2012


Hi,

2012/8/21 Haitao Huang <haitao.huang at intel.com>:
> Change the driver used for android. Libva has to load the correct
> driver and retain the vendor and device id's.
>
> This change is to re-use common drm utils code for driver name
> detection. Also removed non-android code in android specific files
> and unneeded files in android directory.
>
> Change-Id: I2893d8fcadfbf911e7c0b421a4e90d5aeb0d619e
> Signed-off-by: Daniel Charles <daniel.charles at intel.com> (change driver)
> Signed-off-by: Haitao Huang <haitao.huang at intel.com> (update using drm util)

[...]

> diff --git a/va/android/va_android.cpp b/va/android/va_android.cpp
> index 5612c3c..b849eb3 100644
> --- a/va/android/va_android.cpp
> +++ b/va/android/va_android.cpp
> @@ -39,13 +40,10 @@
>  #include <fcntl.h>
>  #include <dlfcn.h>
>  #include <errno.h>
> -#ifndef ANDROID
> -#include <libudev.h>
> -#include "drmtest.h"
> -#endif
> +
>
>  #define CHECK_SYMBOL(func) { if (!func) printf("func %s not found\n", #func); return VA_STATUS_ERROR_UNKNOWN; }
> -#define DEVICE_NAME "/dev/card0"
> +#define DEVICE_NAME "/dev/dri/card0"

Is this change verified to work for all parties? Though, I don't see
any reason why it wouldn't work on PVR.

Thanks,
Gwenole.


More information about the Libva mailing list