[Libva] [PATCH intel-driver 03/13] vebox: fix indication of field ordering in sequence.

Zhao, Yakui yakui.zhao at intel.com
Fri Aug 29 00:16:12 PDT 2014


On Wed, 2014-08-27 at 05:50 -0600, Gwenole Beauchesne wrote:
> VEBOX_DNDI_STATE::dndi_top_first indicates whether the top field is
> first in sequence (TFF), or if the bottom field comes first. This is
> an indication of the temporal sequence for input frames, available
> in the "history" buffer. As such, the correct flag to check against,
> from a VA-API perspective, is VA_DEINTERLACING_BOTTOM_FIELD_FIRST.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=72518
> https://bugs.freedesktop.org/show_bug.cgi?id=72522
> 
> Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne at intel.com>
> ---
>  src/gen75_vpp_vebox.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gen75_vpp_vebox.c b/src/gen75_vpp_vebox.c
> index 76ecc6b..e06d8fe 100644
> --- a/src/gen75_vpp_vebox.c
> +++ b/src/gen75_vpp_vebox.c
> @@ -131,7 +131,7 @@ void hsw_veb_dndi_table(VADriverContextP ctx, struct intel_vebox_context *proc_c
>          assert(di_param);
>  
>          progressive_dn = 0;
> -        dndi_top_first = !(di_param->flags & VA_DEINTERLACING_BOTTOM_FIELD);
> +        dndi_top_first = !(di_param->flags & VA_DEINTERLACING_BOTTOM_FIELD_FIRST);

This makes sense.

Good catch.

Thanks.

>          motion_compensated_enable = (di_param->algorithm == VAProcDeinterlacingMotionCompensated);
>      }
>  




More information about the Libva mailing list