[Libva] [PATCH 0/4] Add support for MVC High profile

[Zhao, Yakui]

On Mon, 2014-06-02 at 11:58 -0600, Gwenole Beauchesne wrote:
> Hi,
> 
> This patch series adds support for H.264 Multiview High profile on
> Haswell and newer generations.
> 
> Support for H.264 Stereo High profile is readily possible with the
> earlier patches for all generations starting from Sandybridge.
> Theoritically, earlier generations (e.g. Ironlake) might also be
> supported but I have not tested them. It's better to stick to hardware
> that support the MFX engine for fixed-function decoding.
> 
> The interesting patch is only the last one. The first three patches
> are only convenience to further factor out the frame store logic. More
> re-factoring is possible and needed. This is not going to be scalable
> to future generations otherwise.

This patch set looks clearer than the previous version. But there still
exist some problems.

   1. The patch can't be applied on the latest staging or master branch.
And it is difficult to review it. Will you please assure that the patch
set is rebased on the latest staging branch ?
   2. Patch 03 uses some structures that is not defined.(Maybe this is
caused by that it is not rebased on the latest staging branch.)
   
   3. If only the last patch is to fix the problem, can it be generated
without the previous too many re-factoring patch? Otherwise it will have
to spend a lot of time on reviewing the re-factoring patch instead of
feature supporting or bug fixing. At the same time it will help to
reduce the possible conflict when chery-picking it from staging to
master.

Thanks
    Yakui
> 
> Regards,
> Gwenole Beauchesne (4):
>   decoder: factor out frame store context.
>   decoder: factor out look ups for VA/H264 picture info.
>   decoder: h264: use frame store context to maintain ref frames.
>   decoder: h264: enable Picture ID Remapping on Haswell and newer.
> 
>  src/gen6_mfd.c           |   63 +++++++-------------
>  src/gen6_mfd.h           |    2 +-
>  src/gen75_mfd.c          |  129 +++++++++++++---------------------------
>  src/gen7_mfd.c           |   63 +++++++-------------
>  src/gen7_mfd.h           |    2 +-
>  src/gen8_mfd.c           |   88 +++++++++-------------------
>  src/i965_avc_bsd.c       |   56 +++++-------------
>  src/i965_decoder.h       |    8 +++
>  src/i965_decoder_utils.c |  146 +++++++++++++++++++++++++++++++++++++++++++---
>  src/i965_decoder_utils.h |   36 ++++++++++--
>  src/i965_media_h264.c    |   37 +++++-------
>  src/i965_media_h264.h    |    3 +-
>  12 files changed, 320 insertions(+), 313 deletions(-)
>