[Libva] [PATCH 0/2] add user specified tiling/stride support, clean up assert

[Gwenole Beauchesne]

Hi,

2014-03-14 10:19 GMT+01:00 Zhao, Halley <halley.zhao at intel.com>:

> when I implements feature for user specified tiling/stride support,
> haihao mentioned that I'd better 'return fail' instead of assert().
> so, I tried to clean up the assert in i965_drv_video.c as well.

The assert_ret() patch did not appear on the list but was committed as 12c8122.

What Haihao mentioned was right, but what I had precisely indicated
beforehand was to not have the VA driver fail at all in the default
case too. Besides, the proposed patch turned down the indication of
what went wrong. i.e. assert(0) is totally meaningless, unless you get
the original source code the binary was built with, and look for the
specified file/line number information.

The proper approach would have been to log the error in any case,
possibly controlled by an environment variable (e.g.
VA_INTEL_DEBUG=asserts), but definitely not an assert(0) again. That
way, you can still get informative enough bug reports. And, most
importantly, you also get a chance to test/exercice the error handling
code of upper layers in the general case too.

Thanks,
Gwenole.