[Libva] [PATCH intel-driver 0/5] Fix support for grayscale

[Gwenole Beauchesne]

Hi,

2014-05-12 3:06 GMT+02:00 Zhao Yakui <yakui.zhao at intel.com>:
> On Sat, 2014-05-10 at 00:03 -0600, Gwenole Beauchesne wrote:
>> Hi,
>>
>> This patch series fixes and optimizes support for grayscale streams (Patch5).
>>
>> Patches 2 to 4 are colateral preparatory work for fixing VA config
>> queries and creation.
>
> Hi, Gwenole
>
>     Are you testing it by using gst-vaapi or ffmpeg?

I am always testing with both.

>     It seems that some player/middleware will still allocate the NV12
> surface instead of MONOCHROME for the grayscale stream.  And the
> MONOCHROME is detected by using the H264 decoding parameter. In such
> case the decode hardware only update the luma component for the NV12
> surface and leave the chroma component alone.
>
> If so, your patch set will break the player/middleware that are using
> the above mechanism.

The patch preserves compatibility with older codec layers that
incorrectly use YUV 4:2:0.

You probably missed Patch5 where this is taken care of. See the
avc_ensure_surface_bo() function. There is an additional check against
the selected VA chroma format set in the config.

Regards,
Gwenole.

>>
>> Regards,
>> Gwenole Beauchesne (5):
>>   surface: fix vaDeriveImage() for grayscale.
>>   config: fix vaGetConfigAttributes() to validate profile/entrypoint.
>>   config: fix vaCreateConfig() to not override user chroma format.
>>   config: fix supported set of chroma formats for JPEG decode.
>>   decoder: h264: optimize support for grayscale surfaces.
>>
>>  src/gen6_mfd.c           |  21 ++--
>>  src/gen75_mfd.c          |  19 +--
>>  src/gen7_mfd.c           |  19 +--
>>  src/gen8_mfd.c           |  19 +--
>>  src/i965_decoder_utils.c |  71 ++++++++++-
>>  src/i965_decoder_utils.h |   8 ++
>>  src/i965_drv_video.c     | 299 ++++++++++++++++++++++++++++++++---------------
>>  src/i965_drv_video.h     |  14 +++
>>  8 files changed, 318 insertions(+), 152 deletions(-)
>>
>
>