[Libva] [PATCH 5/9] shaders: fix out of tree builds

[Emil Velikov]

On 10/11/14 04:44, Xiang, Haihao wrote:
> 
>> Hi Haihao,
>>
>> That is true. The current series it will not pick the files from the
>> builddir, but that is because intel-gen4asm is optional, thus the files
>> will not always be present.
>> I believe that fixing it is an orthogonal issue - I'm trying to get
>> "make distcheck" working in any shape or form. Fixing everything else is
>> part of another series.
> 
> I pushed your patches to the master branch. 
> 
Thanks!

>> And to clarify what I mean with everything else:
>>  - Do not use of m4 to pre-process the headers.
> 
> intel-gen4asm can't recognize some symbols in .gxa (x=4,5,6,7,8) files
> if don't use m4 to pre-process .gxa files.
> 
The ones I've tried were ok. Will keep an eye open for problems :)

>>  - Add android rules to build/assemble the shaders.
>>  - Mandate the presence of intel-gen4asm at build-time.
> 
> I prefer not to mandate the presence of intel-gen4asm. 
> 

Can you elaborate why you prefer to keep intel-gen4asm optional ?
Afaik keeping generated files in version control is a recipe for
disaster, one of which you've already spotted.

Should I close the bugreports that I was requested to open for some of
these patches, or should I leave it to the QA to confirm/close them ?

Cheers,
Emil

> Thanks
> Haihao
> 
> 
>>  - Drop all the in-tree pre-processed and assembled shaders.
>>  - (Parallel to the last point) Make sure that the shaders in the build
>> folder are used.
>>
>> The Android stuff is obviously going to be a pain, yet everything else
>> is dead trivial.
>>
>> Does it make sense or do you prefer that I send a patch that does
>> multiple (seemingly unrelated imho) things at the same time ?
>>
>> Cheers,
>> Emil
>>
>> P.S. Is it normal to have to different files produce the exact same
>> shader - something like PL3_AVS_Buf_2.g8a PL3_AVS_Buf_3.g8a
>> producing the same binary ? Don't remember the exact files so these are
>> just an example.
>>