[Libva] [PATCH 5/9] shaders: fix out of tree builds

[Emil Velikov]

On 11/11/14 08:22, Xiang, Haihao wrote:
[snip]
> 1. For most user, it is unnecessary to use intel-gen4asm. 
I'm guessing that you meant "everyone who builds from the distribution
tarball should not need intel-gen4asm", and yes it does make sense. I
got carried away there.

That means that I'll need to double-check that the binary shaders are
correctly added as dependency for the sources that includes them.
Otherwise make will not pick/build them.

> 2. libva will have a dependency on intel-gen4asm if intel-gen4asm is
> mandatory. However you can't find  intel-gen4asm in some distro, E.g.
> Ubuntu 14.04.
> 
Afaics Ubuntu 10.04 and later (including 14.04) have the package.
Either way that should _not_ be a reason to keep generated sources in
version control. Distributions are meant to complement the development
process, not mandate it :)


Either way, thanks for keeping up with my questions.

>> Should I close the bugreports that I was requested to open for some of
>> these patches, or should I leave it to the QA to confirm/close them ?
> 
> You can mark it as fixed.
> 
Done.

Cheers
Emil