[Libva] [Libva-intel-driver][[PATCH 2/3] Remove the redundant check in vaBeginPicture call

Zhao Yakui yakui.zhao at intel.com
Mon Aug 24 22:35:16 PDT 2015


On 08/25/2015 12:41 PM, Zhao Yakui wrote:
> On 08/25/2015 02:43 PM, Zhao Yakui wrote:
>> The corresponding check is already executed when calling vaCreateConfig.
>> So the redundant check is removed.
>>
>> Signed-off-by: Zhao Yakui<yakui.zhao at intel.com>
>> ---
>> src/i965_drv_video.c | 49
>> -------------------------------------------------
>> 1 file changed, 49 deletions(-)
>>
>> diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
>> index 4059666..8408413 100644
>> --- a/src/i965_drv_video.c
>> +++ b/src/i965_drv_video.c
>> @@ -2313,55 +2313,6 @@ i965_BeginPicture(VADriverContextP ctx,
>> if (is_surface_busy(i965, obj_surface))
>> return VA_STATUS_ERROR_SURFACE_BUSY;
>>
>
> vaStatus should be initialized. Otherwise the incorrect vaStatus is
> returned.

Now the patch is pushed after adding the initialization of vaStatus.

Thanks.
    Yakui

>
>> - switch (obj_config->profile) {
>> - case VAProfileMPEG2Simple:
>> - case VAProfileMPEG2Main:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - case VAProfileH264ConstrainedBaseline:
>> - case VAProfileH264Main:
>> - case VAProfileH264High:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - case VAProfileH264MultiviewHigh:
>> - case VAProfileH264StereoHigh:
>> - if (HAS_H264_MVC_DECODING_PROFILE(i965, obj_config->profile) ||
>> - HAS_H264_MVC_ENCODING(i965)) {
>> - vaStatus = VA_STATUS_SUCCESS;
>> - } else {
>> - ASSERT_RET(0, VA_STATUS_ERROR_UNSUPPORTED_PROFILE);
>> - }
>> - break;
>> -
>> - case VAProfileVC1Simple:
>> - case VAProfileVC1Main:
>> - case VAProfileVC1Advanced:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - case VAProfileJPEGBaseline:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - case VAProfileNone:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - case VAProfileVP8Version0_3:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - case VAProfileHEVCMain:
>> - vaStatus = VA_STATUS_SUCCESS;
>> - break;
>> -
>> - default:
>> - ASSERT_RET(0, VA_STATUS_ERROR_UNSUPPORTED_PROFILE);
>> - break;
>> - }
>> -
>> if (obj_context->codec_type == CODEC_PROC) {
>> obj_context->codec_state.proc.current_render_target = render_target;
>> } else if (obj_context->codec_type == CODEC_ENC) {
>



More information about the Libva mailing list