[Libva] [PATCH] Fix incorrect if status checking in i965_proc_picture.

Zhao Yakui yakui.zhao at intel.com
Tue Nov 17 17:11:50 PST 2015


On 11/18/2015 09:08 AM, Lim Siew Hoon wrote:
> Once the va status return from i965_proc_picture_fast not
> VA_STATUS_SUCCESS, it should be return status and exit from
> from i965_proc_picture instead continue to execuse the
> following code.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=92811
> Signed-off-by: Lim Siew Hoon<siew.hoon.lim at intel.com>
> ---
>   src/i965_post_processing.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/i965_post_processing.c b/src/i965_post_processing.c
> index bf88c94..8bf7619 100755
> --- a/src/i965_post_processing.c
> +++ b/src/i965_post_processing.c
> @@ -5798,7 +5798,7 @@ i965_proc_picture(VADriverContextP ctx,
>       int in_width, in_height;
>
>       status = i965_proc_picture_fast(ctx, proc_context, proc_state);
> -    if (status != VA_STATUS_ERROR_UNIMPLEMENTED)
> +    if (status != VA_STATUS_SUCCESS)
>           return status;

The purpose of proc_picture_fast is to combine some operations together.
If it is not handled/implemented, it will fall back to the original path.

So I don't think that it should exit when it fails on the proc_picture_fast.

Thanks
     Yakui

>
>       if (pipeline_param->surface == VA_INVALID_ID ||



More information about the Libva mailing list