[Libva] [PATCH] Fix for ring hung issue in SNB platform.

Xiang, Haihao haihao.xiang at intel.com
Wed Nov 18 17:14:48 PST 2015


Applied, thanks for the patch. 

BTW it would be better to disable PPGTT on SNB if you are still using
an old kernel. 

Thanks
Haihao


> On 11/18/15, 12:56 AM, "Libva on behalf of Lim Siew Hoon" <libva-boun
> ces at lists.freedesktop.org on behalf of siew.hoon.lim at intel.com>
> wrote:
> 
> > This issue is trigger by the fixed from
> > commit id: 7deaf55d3f927e32e0b2280601dae106c7b9e3d8
> > use to fix segmentation fault issue by checking dst_object->bo
> > is NULL and VA_STATUS_ERROR_UNIMPLEMENTED in i965_proc_picture_fast
> > function will causing GPU hung in ring.
> > 
> > By disable the PPGTT, no more GPU hang issue.
> > 
> > If return VA_STATUS_ERROR_INVALID_SURFACE for checking only
> > dst_obj->bo is NULL, it is working fine without purposely to
> > disable PPGTT.
> > 
> > End up decided to use VA_STATUS_ERROR_INVALID_SURFACE instead
> > VA_STATUS_ERROR_UNIMPLEMENTED for dst_obj->bo checking in
> > i965_proc_picture_fast.
> 
> Lgtm
> 
> 
> > 
> > Signed-off-by: Lim Siew Hoon <siew.hoon.lim at intel.com>
> > ---
> > src/i965_post_processing.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/i965_post_processing.c
> > b/src/i965_post_processing.c
> > index bf88c94..ea35b36 100755
> > --- a/src/i965_post_processing.c
> > +++ b/src/i965_post_processing.c
> > @@ -5724,7 +5724,7 @@ i965_proc_picture_fast(VADriverContextP ctx,
> >         return VA_STATUS_ERROR_INVALID_SURFACE;
> > 
> >     if (!dst_obj_surface->bo)
> > -        return VA_STATUS_ERROR_UNIMPLEMENTED;
> > +        return VA_STATUS_ERROR_INVALID_SURFACE;
> > 
> >     if (dst_obj_surface->fourcc &&
> >         dst_obj_surface->fourcc != src_obj_surface->fourcc)
> > -- 
> > 2.1.0
> > 
> > _______________________________________________
> > Libva mailing list
> > Libva at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libva
> > 
> 
> 
> -- 
> Sean V. Kelley <sean.v.kelley at intel.com>
> Open Source Technology Center / SSG
> Intel Corp.
> 
> 
> 
> _______________________________________________
> Libva mailing list
> Libva at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libva


More information about the Libva mailing list