[Libva] Robust configure without Wayland (see bug 79478)

[Emil Velikov]

Hi Thomas,

On 27 November 2015 at 17:51, Thomas Orgis <sobukus at sourcemage.org> wrote:
> Hi,
>
> I was told to send the attached patch to this list for discussion. It
> is about troubles trying to build libva without wayland stuff
> installed. The configure of libva-1.6.0 fails:
>
> checking for WAYLAND... no
> checking for pkg-config... (cached) /usr/bin/pkg-config
> checking pkg-config is at least version 0.9.0... yes
> checking for WAYLAND_SCANNER... no
> configure: error: Package requirements (wayland-scanner) were not met:
>
> No package 'wayland-scanner' found
>
> Consider adjusting the PKG_CONFIG_PATH environment variable if you
> installed software in a non-standard prefix.
>
> Alternatively, you may set the environment variables WAYLAND_SCANNER_CFLAGS
> and WAYLAND_SCANNER_LIBS to avoid the need to call pkg-config.
> See the pkg-config man page for more details.
>
>
> The same  for libva-1.6.1 works. It also works for 1.6.0 when
> regenerating the configure script using `autoreconf -iv`. The whole
> thing is discussed in
>
>         https://bugs.freedesktop.org/show_bug.cgi?id=79478
>
> and I made a patch that moves the wayland scanner code into the main
> conditional and assume that this should fix things. But: I now realized
> that the simple regeneration of the configure script without any patch
> also works. I guess that a system with wayland installed creates
> configure scripts that fail without wayland and systems without wayland
> create configure scripts that are missing pieces to enable wayland …
>
> I hope future releases of libva can me made to include a configure
> script that works for both cases.
>
>
Admittedly I did not follow the discussion in the bug report, although
here is how mesa has dealt with this problem

http://cgit.freedesktop.org/mesa/mesa/commit/?id=426a23af147720ae3b89995ffee792a29e8ae2db
http://cgit.freedesktop.org/mesa/mesa/commit/?id=153539bd9d4445b504110958306f00632222f840

Hope you find it useful.

Regards,
Emil