[Libva] [PATCH] Update list of authors.

[Emil Velikov]

On 28 October 2015 at 16:14, Gwenole Beauchesne <gb.devel at gmail.com> wrote:
> 2015-10-28 17:00 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:
>> Hi Gwenole,
>>
>> On 28 October 2015 at 15:46, Gwenole Beauchesne <gb.devel at gmail.com> wrote:
>>> Statistics based on precise commits and actual contents (subsytems,
>>> features, etc.). List of contributions could be derived into three
>>> parts: primary/major (100+), regular (15+) and occasional.
>>>
>>> Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne at intel.com>
>>> ---
>>> FYI, this will be pushed by the end of this week.
>>>
>>>  AUTHORS                    | 29 +++++++++++++++++++++++++++++
>>>  src/dso_utils.c            |  3 +++
>>>  src/dso_utils.h            |  3 +++
>>>  src/gen6_mfd.c             |  2 +-
>>>  src/gen75_vpp_vebox.c      |  2 ++
>>>  src/gen7_mfd.c             |  3 ++-
>>>  src/gen8_mfd.c             |  2 +-
>>>  src/i965_decoder_utils.c   |  4 ++++
>>>  src/i965_output_wayland.c  |  3 +++
>>>  src/i965_output_wayland.h  |  3 +++
>>>  src/i965_post_processing.c |  3 ++-
>>>  src/i965_render.c          |  3 ++-
>>>  12 files changed, 55 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/AUTHORS b/AUTHORS
>>> index f296b02..b1965ad 100644
>>> --- a/AUTHORS
>>> +++ b/AUTHORS
>>> @@ -2,9 +2,38 @@ Intel Linux graphics team working on the driver:
>>
>>> +Emil Velikov
>> Wohoo I made it. Let's party :-P
>>
>>> diff --git a/src/dso_utils.c b/src/dso_utils.c
>>> index 8fdea11..217b059 100644
>>> --- a/src/dso_utils.c
>>> +++ b/src/dso_utils.c
>>> @@ -20,6 +20,9 @@
>>>   * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
>>>   * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
>>>   * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>>> + *
>>> + * Authors:
>>> + *    Gwenole Beauchesne <gwenole.beauchesne at intel.com>
>>>   */
>> But seriously what is the purpose of having Authors tag in sources ?
>> Isn't that a relic that many projects are moving away from ? Or
>> perhaps there is some static tool that barfs as it needs/parses them ?
>
> With that particular license?
I was under the impression that license != authorship. Then again
IANAL despite the couple of law & IP classes at Uni.

> Consistency. Either you add missing
> ones, or you drop all others. For existing projects, it's simpler to
> add than remove without troubling too many people. :)
And as other people forget to add themselves you'll need to do this
again and again :-( There is also the question of "what happens if
person moves/copies hunk from X. should one consider him/her the
author ?".

> Besides, you
> don't necessarily have the companion git history to blame specific
> persons or inquire further questions for obscure bugs or ways of
> how/why things work that way.
>
Personally I think that looking at the code without the git/svn/foo
history is a very bad thing. You essentially have no way to tracking
the evolution and reasons (ehm... the sometimes brief commit messages)
why things are done in the specific way.

> The important bits are in AUTHORS at least, with one missing "root"
> for whom it's hard to recover the original identity.
>
Most X.org projects include this hunk, which seems to automate things.
Although I'm not sure where the *_CMD macros come from.

cat $(top)/Makefile.am
...
MAINTAINERCLEANFILES = ChangeLog AUTHORS

.PHONY: ChangeLog AUTHORS

ChangeLog:
   $(CHANGELOG_CMD)

dist-hook: ChangeLog
AUTHORS:
   $(AUTHORS_CMD)

dist-hook: ChangeLog AUTHORS
...


Cheers,
Emil