[Libva] [PATCH] FIX:this patch fix the green line on output pic when do scaling on SKL.

[Qu, Pengfei]

How about use the VA_FILTER_SCALING_DEFAULT for this case as VA_FILTER_SCALING_HQ cause the issue.

-----Original Message-----
From: Xiang, Haihao 
Sent: Tuesday, September 29, 2015 9:49 AM
To: Qu, Pengfei
Cc: libva at lists.freedesktop.org
Subject: Re: [Libva] [PATCH] FIX:this patch fix the green line on output pic when do scaling on SKL.

On Wed, 2015-09-23 at 14:45 +0800, Qu,Pengfei wrote:
> Signed-off-by: Qu,Pengfei <Pengfei.Qu at intel.com>
> ---
>  src/i965_post_processing.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/i965_post_processing.c b/src/i965_post_processing.c 
> index a1c0e4d..2ec34b1 100755
> --- a/src/i965_post_processing.c
> +++ b/src/i965_post_processing.c
> @@ -5966,7 +5966,7 @@ i965_proc_picture(VADriverContextP ctx,
>          intel_batchbuffer_flush(hw_context->batch);
>  
>          saved_filter_flag = i965pp_context->filter_flags;
> -        i965pp_context->filter_flags = VA_FILTER_SCALING_HQ;
> +        i965pp_context->filter_flags = pipeline_param->filter_flags;

pipeline_param->filter_flags can be OR'd with non-scaling flags, it would be better to mask out other flags. 

BTW your patch implies green line was seen with VA_FILTER_SCALING_HQ, the green line issue still exists if VA_FILTER_SCALING_HQ is set in pipeline_param->filter_flags. 


>  
>          dst_surface.base = (struct object_base *)obj_surface;
>          dst_surface.type = I965_SURFACE_TYPE_SURFACE;