[Libva] [PATCH Intel-VA] Add if statement checking for obj_context that possible assign to NULL value.

Zhao Yakui yakui.zhao at intel.com
Tue Sep 29 17:06:10 PDT 2015


On 09/29/2015 05:30 PM, Lim Siew Hoon wrote:
> Signed-off-by: Lim Siew Hoon<siew.hoon.lim at intel.com>

Thanks for the patch.

It is oK to me that more check is added for the obj_context.
In fact this is from the upper caller and it is already checked in the 
caller. (If it is NULL, it will fail in the upper caller).

Of course it is still OK to me that this check is added.

Thanks
   Yakui

> ---
>   src/i965_drv_video.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
> index 9bbd67f..cb950e1 100644
> --- a/src/i965_drv_video.c
> +++ b/src/i965_drv_video.c
> @@ -2813,6 +2813,9 @@ i965_decoder_wrapper_picture(VADriverContextP ctx,
>       VADriverContextP pdrvctx;
>       struct object_buffer *obj_buffer;
>
> +    if (obj_context == NULL)
> +        return VA_STATUS_ERROR_INVALID_CONTEXT;
> +
>       /* When it is not wrapped context, continue the normal flowchart */
>       if (obj_context->wrapper_context == VA_INVALID_ID)
>           return vaStatus;



More information about the Libva mailing list