[Libva] [PATCH] Don't automatically destroy the buffer(s) passed to vaRenderPicture

[Mark Thompson]

On 01/12/16 08:55, Xiang, Haihao wrote:
> Instead the user must call vaDestroyBuffer() to destroy a buffer explicitly.
> 
> If following the previous API specification,
> 1. Violate "who allocate who release" principle
> 2. The user cannot re-use VA buffer flexibly
> 3. The user still has to call vaDestroyBuffer() to destroy the buffers which
>    are not going to be passed to vaRenderPicture()
> 
> We discussed the change at https://bugs.freedesktop.org/show_bug.cgi?id=97970
> 
> Signed-off-by: Xiang, Haihao <haihao.xiang at intel.com>
> ---
>  va/va.h          |  9 +++++++--
>  va/va_enc_h264.h |  3 +--
>  va/va_vpp.h      | 12 +++---------
>  3 files changed, 11 insertions(+), 13 deletions(-)

This is a totally incompatible change to VAAPI, so please make libva before and after this change clearly distinguishable.

Probably you should increment the major version number and change the SONAME of libva, though I realise commercial concerns will likely block that.  At least increment the minor version number if nothing else can be done.

Thanks,

- Mark