[Libva] [PATCH] encode: h264, h265: Remove unnecessary warning

Xiang, Haihao haihao.xiang at intel.com
Fri Jul 22 06:43:09 UTC 2016


Yes these warnings are unnecessary, thanks for your patch, applied.


> From: Sreerenj Balachandran <sreerenj.balachandran at intel.com>
> 
> The warning "Input ref list is Wrong" is generating
> based on assumption that reference frames provided in
> VAEncPictureParameterBuffer are in align with
> ref_pic_list included in VAEncSliceParameterBuffer.
> There shoudn't be such constraints, as per VA specification
> pic_param->reference_frames can have any order based on
> dpb manipulation.
> 
> Signed-off-by: Sreerenj Balachandran <sreerenj.balachandran at intel.com
> >
> ---
>  src/gen6_mfc_common.c | 3 ---
>  src/gen9_mfc_hevc.c   | 4 ----
>  2 files changed, 7 deletions(-)
> 
> diff --git a/src/gen6_mfc_common.c b/src/gen6_mfc_common.c
> index f961ecd..2f9f761 100644
> --- a/src/gen6_mfc_common.c
> +++ b/src/gen6_mfc_common.c
> @@ -1176,9 +1176,6 @@ intel_mfc_avc_ref_idx_state(VADriverContextP
> ctx,
>              fref_entry &= ~(0xFF << ref_idx_l0_shift);
>              fref_entry += (intel_get_ref_idx_state_1(vme_context-
> >used_references[0], frame_index) << ref_idx_l0_shift);
>          }
> -        if(frame_index == 1){
> -            WARN_ONCE("Input ref list is Wrong !\n");
> -        }
>      }
>  
>      if (slice_type == SLICE_TYPE_B) {
> diff --git a/src/gen9_mfc_hevc.c b/src/gen9_mfc_hevc.c
> index ad5e936..7435d2a 100644
> --- a/src/gen9_mfc_hevc.c
> +++ b/src/gen9_mfc_hevc.c
> @@ -714,10 +714,6 @@ gen9_hcpe_ref_idx_state_1(struct
> intel_batchbuffer *batch,
>          WARN_ONCE("RefPicList 0 or 1 is not found in DPB!\n");
>      }
>  
> -    if(num_ref_minus1 == 0 && frame_index == 1 && list == 0){
> -        WARN_ONCE("Input ref list is Wrong !\n");
> -    }
> -
>      BEGIN_BCS_BATCH(batch, 18);
>  
>      OUT_BCS_BATCH(batch, HCP_REF_IDX_STATE | (18 - 2));


More information about the Libva mailing list