[Libva] [PATCH] Changed 'c' variable 'char' data type to 'int' data type (v2)

Lim, Siew Hoon siew.hoon.lim at intel.com
Thu Jul 28 01:22:27 UTC 2016





> -----Original Message-----
> From: Xiang, Haihao
> Sent: Wednesday, July 27, 2016 8:05 PM
> To: Lim, Siew Hoon; libva at lists.freedesktop.org
> Subject: RE: [Libva] [PATCH] Changed 'c' variable 'char' data type to 'int' data
> type (v2)
> 
> putsurface/putsurface_common.c was modified in the first version of the
> patch, is the change not needed any more in the new patch?
> BTW getopt_long function is used in other cases, maybe a similar fix is needed
> for these cases.

[Siew Hoon]  Ops...I miss out it. putsurface/putsurface_common.c also need to change. 
                       I will re-check other cases got make same changed or not.  Re-send the patch.  
	
	  
> 
> Thanks
> Haihao
> 
> >-----Original Message-----
> >From: Libva [mailto:libva-bounces at lists.freedesktop.org] On Behalf Of
> >Lim Siew Hoon
> >Sent: Wednesday, July 27, 2016 4:13 PM
> >To: libva at lists.freedesktop.org
> >Subject: [Libva] [PATCH] Changed 'c' variable 'char' data type to 'int'
> >data type
> >(v2)
> >
> >The getopt_long func is return integer data type is more than 1 bytes.
> >
> >Signed-off-by: Lim Siew Hoon <siew.hoon.lim at intel.com>
> >---
> > test/encode/h264encode.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/test/encode/h264encode.c b/test/encode/h264encode.c index
> >649b245..8d8ea30 100644
> >--- a/test/encode/h264encode.c
> >+++ b/test/encode/h264encode.c
> >@@ -860,7 +860,7 @@ static int print_help(void)
> >
> > static int process_cmdline(int argc, char *argv[])  {
> >-    char c;
> >+    int c;
> >     const struct option long_opts[] = {
> >         {"help", no_argument, NULL, 0 },
> >         {"bitrate", required_argument, NULL, 1 },
> >--
> >2.1.0
> >
> >_______________________________________________
> >Libva mailing list
> >Libva at lists.freedesktop.org
> >https://lists.freedesktop.org/mailman/listinfo/libva


More information about the Libva mailing list