[Libva] [Libva-intel-driver][PATCH] libdrm 2.4.52 is required to avoid the compiler error

[Emil Velikov]

Hi Haihao,

On 4 May 2016 at 18:48, Xiang, Haihao <haihao.xiang at intel.com> wrote:
>   CC       i965_drv_video_la-intel_batchbuffer.lo
> intel_batchbuffer.c: In function 'intel_batchbuffer_emit_reloc64':
> intel_batchbuffer.c:183:24: error: 'drm_intel_bo' has no member named 'offset64'
>     uint64_t offset = bo->offset64 + delta;
>                         ^
> make[3]: *** [i965_drv_video_la-intel_batchbuffer.lo] Error 1
>
> Signed-off-by: Xiang, Haihao <haihao.xiang at intel.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index a6ce360..78470b8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -14,7 +14,7 @@ m4_define([va_api_version], [0.39])
>  m4_define([libva_package_version], [1.7.0])
>
>  # libdrm minimum version requirement
> -m4_define([libdrm_version], [2.4.45])
> +m4_define([libdrm_version], [2.4.52])
>
Close but no cigar. Afaict there is a list of pre-existing issues/bugs
that made you draw the above conclusion:
 - intel-driver depends on libdrm 2.4.45, due to VEBOX which was
introduced in libdrm with 011999927f7.
 - intel-driver extensively uses libdrm_intel, yet configure is
missing a check for it and makefiles are missing the appropriate
CFLAGS/LIBS. The debian build should also be updated afaict.
 - the missing symbol comes from libdrm_intel (haven't checked the
exact version)

There are a few good to have fixes:
 - Swap PKG_CHECK_MODULES and PKG_CHECK_EXISTS for libva-drm,
libva-x11, libva-wayland, egl, wayland-client.
 - Drop the following m4_define statements - va_api_version,
libva_package_version and libdrm_version. One can use a simple
variable for them.
 - Use the full libdrm_intel symbols (types/functions) - see the big
pile of defines in intel_bufmgr.h.
I have some patches that fix the existing usecases in intel-driver,
although please let's not add new ones. Like the ones in the earlier
4.8KLoC megapatch - Implement low power mode on SKL.

And some unused variables that can be squashed...
 - va_full_version_int, has_exec2


Pretty sure that'll keep you guys busy for a bit ;-)

Regards,
Emil