[Libva] [PATCH 4/8] Initialize internal VPP context based on Render ring earlier

Zhao Yakui yakui.zhao at intel.com
Fri Nov 11 06:03:15 UTC 2016


On 11/11/2016 01:40 PM, Xiang, Haihao wrote:
> On Wed, 2016-11-09 at 14:39 -0500, Zhao Yakui wrote:
>> Signed-off-by: Zhao Yakui<yakui.zhao at intel.com>
>> ---
>>   src/gen75_picture_process.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/src/gen75_picture_process.c
>> b/src/gen75_picture_process.c
>> index 0b681f1..95bbcd6 100644
>> --- a/src/gen75_picture_process.c
>> +++ b/src/gen75_picture_process.c
>> @@ -148,6 +148,12 @@ gen75_proc_picture(VADriverContextP ctx,
>>           goto error;
>>       }
>>
>> +    if (pipeline_param->num_filters == 0 || pipeline_param->filters
>> == NULL ){
>> +        /* explicitly initialize the VPP based on Render ring */
>> +        if (proc_ctx->vpp_fmt_cvt_ctx == NULL)
>> +            proc_ctx->vpp_fmt_cvt_ctx = i965_proc_context_init(ctx,
>> NULL);
>> +    }
>> +
>
> If so, the code to set  proc_ctx->vpp_fmt_cvt_ctx in
> gen75_vpp_fmt_cvt() is unnecessary now, could you remove it?

Sure. It will be removed in next version.
Thanks for the review.

>
>
>>       if (!obj_dst_surf->bo) {
>>           unsigned int is_tiled = 1;
>>           unsigned int fourcc = VA_FOURCC_NV12;



More information about the Libva mailing list