[Libva] [PATCH] va/x11: Require synchronisation to vblank with DRI2SwapBuffers

[Sean V Kelley]

On Thu, 2016-11-17 at 01:22 +0000, Xiang, Haihao wrote:
> Hi,
> 
> Someone got lockup with this patch and I don't see the issue is
> resolved, please check the thread below
> 
> https://lists.freedesktop.org/archives/intel-gfx/2015-December/083572
> .h
> tml  ([Intel-gfx] vsync + vaapi question).
> 
> and this is the last response:
> 
> https://lists.freedesktop.org/archives/intel-gfx/2015-December/083862
> .h
> tml
> 
> I will revert this patch until we root the cause.


Good catch Haihao, I had assumed it was resolved.

Sean

> 
> Thanks
> Haihao
> 
> 
> > On Wed, Nov 16, 2016 at 1:35 AM, Chris Wilson <chris at chris-wilson.c
> > o.
> > uk> wrote:
> > > On Thu, Dec 24, 2015 at 03:48:07PM +0000, Chris Wilson wrote:
> > > > On Thu, Dec 24, 2015 at 03:42:37PM +0000, Chris Wilson wrote:
> > > > > By passing divisor=0, we imply we do not care about
> > > > > synchronisation of
> > > > > this request to the vertical refresh - the spec says that if
> > > > > we
> > > > > miss the
> > > > > target frame, the swap will be presented as quickly as
> > > > > possible
> > > > > and may
> > > > > forgo waiting until the next vblank. By using divisor=1, we
> > > > > request that
> > > > > the swap be presented upon the vertical refresh immediately
> > > > > following
> > > > > recipe, enforcing the synchronisation to vblank and avoiding
> > > > > tearing.
> > > > 
> > > >   ^receipt
> > > 
> > > Ping.
> > > -Chris
> > > 
> > 
> > 
> > This fell through, this is fine.
> > 
> > lgtm, applied.
> > 
> > Sean
> > 
> > 
> > > --
> > > Chris Wilson, Intel Open Source Technology Centre
> > > _______________________________________________
> > > Libva mailing list
> > > Libva at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/libva
> > 
> > 
> > 
> 
> _______________________________________________
> Libva mailing list
> Libva at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libva
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/libva/attachments/20161116/201a4503/attachment.sig>