[Libva] [PATCH] drm: remove va_drm_is_authenticated check

[Sean V Kelley]

On Thu, 2016-11-17 at 16:42 +0000, Emil Velikov wrote:
> On 17 November 2016 at 15:38, Xiang, Haihao <haihao.xiang at intel.com>
> wrote:
> > > From: Libva [mailto:libva-bounces at lists.freedesktop.org] On
> > > Behalf Of Emil
> > > Velikov
> > > Sent: Tuesday, November 15, 2016 11:24 PM
> > > To: libva at lists.freedesktop.org
> > > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>; David Herrmann
> > > <dh.herrmann at gmail.com>
> > > Subject: [Libva] [PATCH] drm: remove va_drm_is_authenticated
> > > check
> > > 
> > > If we do not use a render node we must authenticate.
> > 
> > It is not true.  A root or master user can access /dev/dri/card0
> > without authentication in drm.
> > va_drm_is_authenticated() is used to check for this cases.
> > 
> 
> Surely you're not suggesting that running your video player as root
> is
> a wise idea ;-)

Agreed.

> 
> Regardless, there's something _really_ fishy with libva if it needs
> va_drm_is_authenticated.
> Any other software out there does not need to (or do so) - some
> examples include Xorg, Wayland and other Weston compositors, Mesa,
> IGT
> (a ton of GPU tests) ... be that as root, user or otherwise.


We don't need it, in my opinion.

Sean

> 
> Emil
> _______________________________________________
> Libva mailing list
> Libva at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libva
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/libva/attachments/20161117/c3f3b920/attachment.sig>