[Libva] [PATCH] va/x11: Require synchronisation to vblank with DRI2SwapBuffers

[Xiang, Haihao]

> On Thu, 2016-11-17 at 08:15 +0000, Xiang, Haihao wrote:
> > But in Lukas's comment:
> > 
> > "Had to revert it because of number of hard lockups."
> > 
> > Did you have other patch to fix the lockup issue in other component
> > or
> > does the issue has gone away? If not, We have to revert the
> >  patch
> > otherwise user will suffer lockup issue with libva.
> > 
> +Focus
> 
> You are making too many assumptions here.  I don't have a problem
> with
> the patch per se and if it will alleviate your concern we can run
> some
> smoke tests on it.  Ambiguous and unreproduced error reports from a
> patch does not a revert make...So ask Focus to run some tests.

The patch enforces synchronization now, so we should make sure it works
in a normal usage. I don't think the report is ambiguous as the
reporter said lockups are gone after reverting the patch. However many
things are changed since last year, I agree we can run some tests to
verify it.



> 
> 
> Thanks,
> 
> Sean
> 
> 
> > Thanks
> > Haihao
> > 
> > 
> > > On Thu, Nov 17, 2016 at 01:22:28AM +0000, Xiang, Haihao wrote:
> > > > 
> > > > Hi,
> > > > 
> > > > Someone got lockup with this patch and I don't see the issue is
> > > > resolved, please check the thread below
> > > > 
> > > > https://lists.freedesktop.org/archives/intel-gfx/2015-December/
> > > > 08
> > > > 35
> > > > 72.h
> > > > tml  ([Intel-gfx] vsync + vaapi question).
> > > > 
> > > > and this is the last response:
> > > > 
> > > > https://lists.freedesktop.org/archives/intel-gfx/2015-December/
> > > > 08
> > > > 38
> > > > 62.h
> > > > tml
> > > > 
> > > > I will revert this patch until we root the cause.
> > > 
> > > This is not the cause of the lockup.
> > > -Chris
> > > 
> > 
> > _______________________________________________
> > Libva mailing list
> > Libva at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/libva