[Libva] [PATCH intel-driver 0/4] Test Environment and some AVC Enc/Dec Tests

Sean V Kelley seanvk at posteo.de
Thu Oct 6 21:01:23 UTC 2016


On Wed, 2016-10-05 at 10:54 -0700, U. Artie Eoff wrote:
> This patch series moves the responsibility of the VADisplay creation
> and vaInitialize/vaTerminate sequence to a I965TestEnvironment
> singleton class.  This environment is added to the GTest global test
> environment so that those aforementioned responsibilities are
> handled during the environment SetUp and TearDown (which are executed
> by GTest before and after executing the *test suite*).  In essence,
> only one VADisplay is created and shared amongst all the test cases
> for each run of the test suite.  This also allows tests to obtain
> the VADisplay instance outside of the I965TestFixture.  As of which
> allows for a simpler, common I965ConfigTest fixture to be defined
> (part of this series).
> 
> Finally, included in this series are AVC enc/dec CreateConfig test
> cases that use the common I965ConfigTest fixture.  Additionally,
> the appropriate JPEG enc/dec cases (Entrypoint) now use the common
> test fixture.


I'm glad you are doing this now rather than later - after adding more
codecs.

lgtm, applied.

Thanks,

Sean

> 
> U. Artie Eoff (4):
>   test: move vaInitialize/vaTerminate to a global test environment
>   test: add ostream operators for VAProfile and VAEntrypoint
>   test: add avce/avcd create config tests
>   test: use common I965ConfigTest fixture for jpeg enc/dec
> 
>  test/Makefile.am                |  10 +++-
>  test/i965_avcd_config_test.cpp  |  72 ++++++++++++++++++++++++++
>  test/i965_avce_config_test.cpp  | 109
> ++++++++++++++++++++++++++++++++++++++++
>  test/i965_config_test.cpp       |  63 +++++++++++++++++++++++
>  test/i965_config_test.h         |  56 +++++++++++++++++++++
>  test/i965_jpeg_decode_test.cpp  |  22 --------
>  test/i965_jpeg_encode_test.cpp  |  18 -------
>  test/i965_jpegd_config_test.cpp |  50 ++++++++++++++++++
>  test/i965_jpege_config_test.cpp |  57 +++++++++++++++++++++
>  test/i965_streamable.h          |  84
> +++++++++++++++++++++++++++++++
>  test/i965_test_environment.cpp  |  86
> +++++++++++++++++++++++++++++++
>  test/i965_test_environment.h    | 100
> ++++++++++++++++++++++++++++++++++++
>  test/i965_test_fixture.cpp      |  94 ------------------------------
> ----
>  test/i965_test_fixture.h        |  72 ++++----------------------
>  test/test_main.cpp              |   4 ++
>  15 files changed, 699 insertions(+), 198 deletions(-)
>  create mode 100644 test/i965_avcd_config_test.cpp
>  create mode 100644 test/i965_avce_config_test.cpp
>  create mode 100644 test/i965_config_test.cpp
>  create mode 100644 test/i965_config_test.h
>  create mode 100644 test/i965_jpegd_config_test.cpp
>  create mode 100644 test/i965_jpege_config_test.cpp
>  create mode 100644 test/i965_test_environment.cpp
>  create mode 100644 test/i965_test_environment.h
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/libva/attachments/20161006/75212d20/attachment.sig>


More information about the Libva mailing list