[Libva] [PATCH intel-driver 0/2] Speed up jpeg encode tests

Eoff, Ullysses A ullysses.a.eoff at intel.com
Sat Oct 15 02:22:10 UTC 2016


Very nice speed improvement!  I was not aware of std::valarray.

I have one minor comment in the first patch.  Other than that, LGTM.

We don't have to do it now, but perhaps we could use a std::valarray as the
underlying type for ::JPEG::Encode::TestInput::bytes to avoid some of the extra
copies and reduce the memory usage footprint, too.  But that would be an
optimization we can do in a later patchset.

Cheers,
U. Artie Eoff

> -----Original Message-----
> From: Phillips, Scott D
> Sent: Friday, October 14, 2016 4:59 PM
> To: libva at lists.freedesktop.org
> Cc: Eoff, Ullysses A <ullysses.a.eoff at intel.com>
> Subject: [PATCH intel-driver 0/2] Speed up jpeg encode tests
> 
> For me these two patches take the Big encode test from 44sec to ~7sec.
> 
> Scott D Phillips (2):
>   test: use valarray for raw image comparison
>   test: read jpeg test data from /dev/urandom
> 
>  test/i965_jpeg_encode_test.cpp | 29 +++++++++++++----------------
>  test/i965_jpeg_test_data.cpp   |  6 +++---
>  2 files changed, 16 insertions(+), 19 deletions(-)
> 
> --
> 2.7.4



More information about the Libva mailing list