[Libva] [Libva-intel-driver][PATCH v2 01/18] intel_mfc_brc_prepare() only works for H.264 or H.264 MVC

[Zhao Yakui]

On 09/09/2016 04:47 AM, Sean V Kelley wrote:
> On Thu, 2016-09-08 at 22:44 +0800, Xiang, Haihao wrote:
>> v2: rebased
>>
>> Signed-off-by: Xiang, Haihao<haihao.xiang at intel.com>
>
>
> Haihao,
>
> It would be good to add a cover for the patch series going over the
> SVC/SVC-T support you are adding for CQP/CBR.

[Yakui}: This is a good idea.
      As the patch set includes 18 patches, one cover patch can help to 
describe the problem.

>
> Also, we need to get a Tested-by: for Libyami's recent commit.
>
> https://github.com/01org/libyami/commit/ea0b5fd79715d0a154b79319d113cf5
> 0e2e9b75e
>
> Has this been tested yet?

[Yakui]: One libva test case is already added. It can test the basic 
function. Of course if it is tested by the mentioned libyami, it is 
great. But I don't that it is prerequisite.

Thanks
    Yakui
>
> Conversely, we can test from gst-vaapi, but I think Sree was waiting
> for the merge to complete the SVC-T support.
>
> Thanks,
>
> Sean
>
>> ---
>>   src/gen6_mfc_common.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/gen6_mfc_common.c b/src/gen6_mfc_common.c
>> index faabbe7..9522c4f 100644
>> --- a/src/gen6_mfc_common.c
>> +++ b/src/gen6_mfc_common.c
>> @@ -422,9 +422,12 @@ void intel_mfc_brc_prepare(struct encode_state
>> *encode_state,
>>       unsigned int rate_control_mode = encoder_context-
>>> rate_control_mode;
>>       struct gen6_mfc_context *mfc_context = encoder_context-
>>> mfc_context;
>>
>> +    if (encoder_context->codec != CODEC_H264&&
>> +        encoder_context->codec != CODEC_H264_MVC)
>> +        return;
>> +
>>       if (rate_control_mode == VA_RC_CBR) {
>>           bool brc_updated;
>> -        assert(encoder_context->codec != CODEC_MPEG2);
>>
>>           brc_updated = intel_mfc_brc_updated_check(encode_state,
>> encoder_context);
>>
>>
>>
>> _______________________________________________
>> Libva mailing list
>> Libva at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/libva