[Libva] [PATCH v1 0/9]Encoder Architecture Changes (Primarily AVC)

[Qu, Pengfei]

-----Original Message-----
From: Zhao, Yakui 
Sent: Tuesday, January 17, 2017 10:30 AM
To: Qu, Pengfei <pengfei.qu at intel.com>
Cc: libva at lists.freedesktop.org
Subject: Re: [Libva] [PATCH v1 0/9]Encoder Architecture Changes (Primarily AVC)

On 01/13/2017 05:24 PM, Pengfei Qu wrote:
> Encoder architecture restructuring for H.264 (with some impact to HEVC 
> now) on HSW+
> * Improvements to the shaders
> * Improvements to the B frame efficiency
> * Improvements to the low bit rate mode
> * Improved features in two stage VME/PAK pipeline
>
> v1:
> Reduce the patch number and re org for VME and MFX related patches.
> Patch re org for VME pipeline
> Patch re org for MFX pipeline
> keep assert for internal logic and replace assert for input validation function.
> Remove unnecessary comments and enum value.
> Use the 64bit version OUT_BCS_RELOC64.
> Move kernel binary into header file.
> use misc parameter from encoder_context structure.
>

The patch set looks much clearer.

But it seems that sometimes the newly added file is not added into src/Makefile.am in time. In such case it is not compiled before the last patch is applied.

It will be better that the newly added file is added into src/Makefile.am in time, which is also convenient to cherry-pick them.
[Pengfei] sure. As there are big code changes in this series patches and so add into Makefile.am at the last patch. 
>
> Pengfe (9):
>    ENC: move gpe related function into src/i965_gpe_utils.h/c
>    ENC: add common structure for AVC/HEVC encoder
>    ENC: add const data/table for AVC encoder
>    ENC: add AVC kernel binary on SKL
>    ENC: add AVC common structure and functions
>    ENC: add kernel related structure and define for AVC
>    ENC: add VME pipeline for AVC encoder
>    ENC: add MFX pipeline for AVC encoder
>    ENC:support more quality level and switch to new AVC encoder solution
>      on SKL
>
>   src/Makefile.am                |    10 +
>   src/gen9_avc_const_def.c       |  1090 ++++
>   src/gen9_avc_const_def.h       |   115 +
>   src/gen9_avc_encoder.c         |  7630 +++++++++++++++++++++++++
>   src/gen9_avc_encoder.h         |  2339 ++++++++
>   src/gen9_avc_encoder_kernels.h | 12078 +++++++++++++++++++++++++++++++++++++++
>   src/gen9_vp9_encoder.c         |   154 +-
>   src/gen9_vp9_encoder.h         |    10 -
>   src/i965_avc_encoder_common.c  |   319 ++
>   src/i965_avc_encoder_common.h  |   305 +
>   src/i965_defines.h             |     3 +
>   src/i965_drv_video.c           |     8 +-
>   src/i965_drv_video.h           |     2 +
>   src/i965_encoder.c             |    52 +-
>   src/i965_encoder_api.h         |    47 +
>   src/i965_encoder_common.c      |   124 +
>   src/i965_encoder_common.h      |   541 ++
>   src/i965_gpe_utils.c           |   282 +
>   src/i965_gpe_utils.h           |    86 +
>   19 files changed, 25027 insertions(+), 168 deletions(-)
>   create mode 100755 src/gen9_avc_const_def.c
>   create mode 100755 src/gen9_avc_const_def.h
>   create mode 100755 src/gen9_avc_encoder.c
>   create mode 100755 src/gen9_avc_encoder.h
>   create mode 100755 src/gen9_avc_encoder_kernels.h
>   create mode 100755 src/i965_avc_encoder_common.c
>   create mode 100755 src/i965_avc_encoder_common.h
>   create mode 100755 src/i965_encoder_api.h
>   create mode 100755 src/i965_encoder_common.c
>   create mode 100755 src/i965_encoder_common.h
>