[Libva] [PATCH v1 2/9] ENC: add common structure for AVC/HEVC encoder

[Qu, Pengfei]

Yes. I will fix it.

-----Original Message-----
From: Mark Thompson [mailto:sw at jkqxz.net] 
Sent: Sunday, January 22, 2017 7:28 AM
To: libva at lists.freedesktop.org; Qu, Pengfei <pengfei.qu at intel.com>
Subject: Re: [Libva] [PATCH v1 2/9] ENC: add common structure for AVC/HEVC encoder

Two minor cosmetic issues:

On 13/01/17 09:24, Pengfei Qu wrote:
> add context init function for AVC encoder
> 
> Signed-off-by: Pengfei Qu <Pengfei.Qu at intel.com>
> Reviewed-by: Sean V Kelley<seanvk at posteo.de>
> ---
>  src/i965_encoder_api.h    |  47 ++++
>  src/i965_encoder_common.c | 124 +++++++++++  
> src/i965_encoder_common.h | 533 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 704 insertions(+)
>  create mode 100755 src/i965_encoder_api.h  create mode 100755 
> src/i965_encoder_common.c  create mode 100755 
> src/i965_encoder_common.h

Many of your new files have the execute bit set, in this and other patches.

> ...
> diff --git a/src/i965_encoder_common.c b/src/i965_encoder_common.c new 
> file mode 100755 index 0000000..930aba9
> --- /dev/null
> +++ b/src/i965_encoder_common.c
> @@ -0,0 +1,124 @@
> +/*
> + * Copyright ? 2016 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person 
> +obtaining a
> + * copy of this software and associated documentation files (the
> + * "Software"), to deal in the Software without restriction, 
> +including
> + * without limitation the rights to use, copy, modify, merge, 
> +publish,
> + * distribute, sub license, and/or sell copies of the Software, and 
> +to
> + * permit persons to whom the Software is furnished to do so, subject 
> +to
> + * the following conditions:
> + *
> + * The above copyright notice and this permission notice (including 
> +the
> + * next paragraph) shall be included in all copies or substantial 
> +portions
> + * of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, 
> +EXPRESS
> + * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
> + * IN NO EVENT SHALL PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE 
> +FOR
> + * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF 
> +CONTRACT,
> + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
> + * SOFTWAR
> + *

Similarly, the licence header on some new files is truncated.

- Mark