<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> AVC SPEC only allow max 16 frames for 1080P at level 5.1. and Level 4/4.1/4.2 only allow max 4 ref frames. And level 5 allow max 13 ref frames for 1080P.<o:p></o:p> <o:p> </o:p> Here the user should be careful when set “denom”. The driver now use the default value “1” to set the VME. it is safe by now.<o:p></o:p> <a name="_MailEndCompose"><o:p> </o:p></a> Thanks,<o:p></o:p> Pengfei<o:p></o:p> <a name="_____replyseparator"></a>From: Peter Frühberger [mailto:peter.fruehberger@gmail.com] Sent: Saturday, July 9, 2016 2:05 PM To: Qu, Pengfei <pengfei.qu@intel.com> Cc: libva@lists.freedesktop.org; Meng, Jia <jia.meng@intel.com> Subject: Re: [Libva] [PATCH 11/13] Adjust the maximum number of motion vectors for B frame on HSW+<o:p></o:p> <o:p> </o:p> <div> Be careful here, please,<o:p></o:p> <div> <o:p> </o:p> </div> <div> some real life files lie about their spec, e.g. they are announcing Level 4.1 High but ship 16 Reframes at 1920x1080. Afaik mpeg-2 always uses 2 (one past and one future). That would result in pixelation, right?<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> Best regards<o:p></o:p> </div> <div> Peter<o:p></o:p> </div> </div> <div> <o:p> </o:p> <div> 2016-07-07 11:18 GMT+02:00 Pengfei Qu <<a href="mailto:Pengfei.Qu@intel.com" target="_blank">Pengfei.Qu@intel.com</a>>:<o:p></o:p> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> From: Jia Meng <<a href="mailto:jia.meng@intel.com">jia.meng@intel.com</a>> Signed-off-by: Jia Meng <<a href="mailto:jia.meng@intel.com">jia.meng@intel.com</a>> Signed-off-by: Pengfei Qu <<a href="mailto:Pengfei.Qu@intel.com">Pengfei.Qu@intel.com</a>> --- src/gen75_vme.c | 13 +++++++------ src/gen8_vme.c | 15 ++++++++------- src/gen9_vme.c | 17 +++++++++-------- 3 files changed, 24 insertions(+), 21 deletions(-) diff --git a/src/gen75_vme.c b/src/gen75_vme.c index 174a642..81925fe 100644 --- a/src/gen75_vme.c +++ b/src/gen75_vme.c @@ -330,7 +330,8 @@ static VAStatus gen75_vme_interface_setup(VADriverContextP ctx, static VAStatus gen75_vme_constant_setup(VADriverContextP ctx, struct encode_state *encode_state, - struct intel_encoder_context *encoder_context) + struct intel_encoder_context *encoder_context, + int denom) { struct gen6_vme_context *vme_context = encoder_context->vme_context; unsigned char *constant_buffer; @@ -342,13 +343,13 @@ static VAStatus gen75_vme_constant_setup(VADriverContextP ctx, if (encoder_context->codec == CODEC_H264 || encoder_context->codec == CODEC_H264_MVC) { if (vme_context->h264_level >= 30) { - mv_num = 16; + mv_num = 16 / denom; if (vme_context->h264_level >= 31) - mv_num = 8; + mv_num = 8 / denom; } } else if (encoder_context->codec == CODEC_MPEG2) { - mv_num = 2; + mv_num = 2 / denom; } vme_state_message[31] = mv_num; @@ -675,7 +676,7 @@ static VAStatus gen75_vme_prepare(VADriverContextP ctx, gen75_vme_surface_setup(ctx, encode_state, is_intra, encoder_context); gen75_vme_interface_setup(ctx, encode_state, encoder_context); //gen75_vme_vme_state_setup(ctx, encode_state, is_intra, encoder_context); - gen75_vme_constant_setup(ctx, encode_state, encoder_context); + gen75_vme_constant_setup(ctx, encode_state, encoder_context, (pSliceParameter->slice_type == SLICE_TYPE_B) ? 2 : 1); /*Programing media pipeline*/ gen75_vme_pipeline_programing(ctx, encode_state, encoder_context); @@ -987,7 +988,7 @@ gen75_vme_mpeg2_prepare(VADriverContextP ctx, gen75_vme_interface_setup(ctx, encode_state, encoder_context); gen75_vme_vme_state_setup(ctx, encode_state, slice_param->is_intra_slice, encoder_context); intel_vme_mpeg2_state_setup(ctx, encode_state, encoder_context); - gen75_vme_constant_setup(ctx, encode_state, encoder_context); + gen75_vme_constant_setup(ctx, encode_state, encoder_context, 1); /*Programing media pipeline*/ gen75_vme_mpeg2_pipeline_programing(ctx, encode_state, slice_param->is_intra_slice, encoder_context); diff --git a/src/gen8_vme.c b/src/gen8_vme.c index 28b8195..f4a874e 100644 --- a/src/gen8_vme.c +++ b/src/gen8_vme.c @@ -363,7 +363,8 @@ static VAStatus gen8_vme_interface_setup(VADriverContextP ctx, static VAStatus gen8_vme_constant_setup(VADriverContextP ctx, struct encode_state *encode_state, - struct intel_encoder_context *encoder_context) + struct intel_encoder_context *encoder_context, + int denom) { struct gen6_vme_context *vme_context = encoder_context->vme_context; unsigned char *constant_buffer; @@ -375,13 +376,13 @@ static VAStatus gen8_vme_constant_setup(VADriverContextP ctx, if (encoder_context->codec == CODEC_H264 || encoder_context->codec == CODEC_H264_MVC) { if (vme_context->h264_level >= 30) { - mv_num = 16; + mv_num = 16 / denom; if (vme_context->h264_level >= 31) - mv_num = 8; + mv_num = 8 / denom; } } else if (encoder_context->codec == CODEC_MPEG2) { - mv_num = 2; + mv_num = 2 / denom; } vme_state_message[31] = mv_num; @@ -749,7 +750,7 @@ static VAStatus gen8_vme_prepare(VADriverContextP ctx, gen8_vme_surface_setup(ctx, encode_state, is_intra, encoder_context); gen8_vme_interface_setup(ctx, encode_state, encoder_context); //gen8_vme_vme_state_setup(ctx, encode_state, is_intra, encoder_context); - gen8_vme_constant_setup(ctx, encode_state, encoder_context); + gen8_vme_constant_setup(ctx, encode_state, encoder_context, (pSliceParameter->slice_type == SLICE_TYPE_B) ? 2 : 1); /*Programing media pipeline*/ gen8_vme_pipeline_programing(ctx, encode_state, encoder_context); @@ -1139,7 +1140,7 @@ gen8_vme_mpeg2_prepare(VADriverContextP ctx, gen8_vme_interface_setup(ctx, encode_state, encoder_context); //gen8_vme_vme_state_setup(ctx, encode_state, slice_param->is_intra_slice, encoder_context); intel_vme_mpeg2_state_setup(ctx, encode_state, encoder_context); - gen8_vme_constant_setup(ctx, encode_state, encoder_context); + gen8_vme_constant_setup(ctx, encode_state, encoder_context, 1); /*Programing media pipeline*/ gen8_vme_mpeg2_pipeline_programing(ctx, encode_state, slice_param->is_intra_slice, encoder_context); @@ -1272,7 +1273,7 @@ static VAStatus gen8_vme_vp8_prepare(VADriverContextP ctx, /*Setup all the memory object*/ gen8_vme_vp8_surface_setup(ctx, encode_state, is_intra, encoder_context); gen8_vme_interface_setup(ctx, encode_state, encoder_context); - gen8_vme_constant_setup(ctx, encode_state, encoder_context); + gen8_vme_constant_setup(ctx, encode_state, encoder_context, 1); /*Programing media pipeline*/ gen8_vme_vp8_pipeline_programing(ctx, encode_state, is_intra, encoder_context); diff --git a/src/gen9_vme.c b/src/gen9_vme.c index 46ba9c0..b495f28 100644 --- a/src/gen9_vme.c +++ b/src/gen9_vme.c @@ -400,7 +400,8 @@ static VAStatus gen9_vme_interface_setup(VADriverContextP ctx, static VAStatus gen9_vme_constant_setup(VADriverContextP ctx, struct encode_state *encode_state, - struct intel_encoder_context *encoder_context) + struct intel_encoder_context *encoder_context, + int denom) { struct gen6_vme_context *vme_context = encoder_context->vme_context; unsigned char *constant_buffer; @@ -412,13 +413,13 @@ static VAStatus gen9_vme_constant_setup(VADriverContextP ctx, if (encoder_context->codec == CODEC_H264 || encoder_context->codec == CODEC_H264_MVC) { if (vme_context->h264_level >= 30) { - mv_num = 16; + mv_num = 16 / denom; if (vme_context->h264_level >= 31) - mv_num = 8; + mv_num = 8 / denom; } } else if (encoder_context->codec == CODEC_MPEG2) { - mv_num = 2; + mv_num = 2 / denom; }else if (encoder_context->codec == CODEC_HEVC) { if (vme_context->hevc_level >= 30*3) { mv_num = 16; @@ -795,7 +796,7 @@ static VAStatus gen9_vme_prepare(VADriverContextP ctx, gen9_vme_surface_setup(ctx, encode_state, is_intra, encoder_context); gen9_vme_interface_setup(ctx, encode_state, encoder_context); //gen9_vme_vme_state_setup(ctx, encode_state, is_intra, encoder_context); - gen9_vme_constant_setup(ctx, encode_state, encoder_context); + gen9_vme_constant_setup(ctx, encode_state, encoder_context, (pSliceParameter->slice_type == SLICE_TYPE_B) ? 2 : 1); /*Programing media pipeline*/ gen9_vme_pipeline_programing(ctx, encode_state, encoder_context); @@ -1187,7 +1188,7 @@ gen9_vme_mpeg2_prepare(VADriverContextP ctx, gen9_vme_interface_setup(ctx, encode_state, encoder_context); //gen9_vme_vme_state_setup(ctx, encode_state, slice_param->is_intra_slice, encoder_context); intel_vme_mpeg2_state_setup(ctx, encode_state, encoder_context); - gen9_vme_constant_setup(ctx, encode_state, encoder_context); + gen9_vme_constant_setup(ctx, encode_state, encoder_context, 1); /*Programing media pipeline*/ gen9_vme_mpeg2_pipeline_programing(ctx, encode_state, slice_param->is_intra_slice, encoder_context); @@ -1322,7 +1323,7 @@ static VAStatus gen9_vme_vp8_prepare(VADriverContextP ctx, /*Setup all the memory object*/ gen9_vme_vp8_surface_setup(ctx, encode_state, is_intra, encoder_context); gen9_vme_interface_setup(ctx, encode_state, encoder_context); - gen9_vme_constant_setup(ctx, encode_state, encoder_context); + gen9_vme_constant_setup(ctx, encode_state, encoder_context, 1); /*Programing media pipeline*/ gen9_vme_vp8_pipeline_programing(ctx, encode_state, is_intra, encoder_context); @@ -1754,7 +1755,7 @@ static VAStatus gen9_vme_hevc_prepare(VADriverContextP ctx, gen9_vme_hevc_surface_setup(ctx, encode_state, is_intra, encoder_context); gen9_vme_interface_setup(ctx, encode_state, encoder_context); //gen9_vme_vme_state_setup(ctx, encode_state, is_intra, encoder_context); - gen9_vme_constant_setup(ctx, encode_state, encoder_context); + gen9_vme_constant_setup(ctx, encode_state, encoder_context, 1); /*Programing media pipeline*/ gen9_vme_hevc_pipeline_programing(ctx, encode_state, encoder_context); -- 2.7.4 _______________________________________________ Libva mailing list <a href="mailto:Libva@lists.freedesktop.org">Libva@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/libva" target="_blank">https://lists.freedesktop.org/mailman/listinfo/libva</a><o:p></o:p> </blockquote> </div> <o:p></o:p> <div> <o:p> </o:p> </div> -- <o:p></o:p> <div> Key-ID: 0x1A995A9B keyserver: <a href="http://pgp.mit.edu" target="_blank">pgp.mit.edu</a> ============================================================== Fingerprint: 4606 DA19 EC2E 9A0B 0157 C81B DA07 CF63 1A99 5A9B<o:p></o:p> </div> </div> </div> </body> </html>