<html><head></head><body><div class="-x-evo-paragraph -x-evo-top-signature-spacer">Hi Sree,</div><div><br></div><div><br></div><div>On Thu, 2016-08-11 at 14:55 +0300, sreerenj.balachandran@intel.com wrote:</div><blockquote type="cite"><pre>From: Sreerenj Balachandran <<a href="mailto:sreerenj.balachandran@intel.com">sreerenj.balachandran@intel.com</a>>
Low power encode through VDENC supports both CBR and VBR.
Make sure vaGetConfigAttribute correctly returns the supported
list of rate control modes in VAEntrypointEncSliceLP entrypoint.
</pre></blockquote><div><br></div><div>This was intentional. I'd prefer to delay this until we get the GuC/HuC kernel patches merged. BRC depends on the HuC firmware...</div><div><br></div><div></div><div><a href="https://patchwork.freedesktop.org/series/9011/">https://patchwork.freedesktop.org/series/9011/</a></div><div><br></div><div>I'm also trying to get an interface (outside of debugfs) for the driver to detect HuC FW loading</div><div>status in the revised/new patch set. We'll be reusing I915_GETPARAM likely.</div><div><br></div><div><br></div><div>Thanks,</div><div><br></div><div>Sean</div><div><br></div><blockquote type="cite"><pre>---
src/i965_device_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/i965_device_info.c b/src/i965_device_info.c
index 47fd50a..a3a1027 100644
--- a/src/i965_device_info.c
+++ b/src/i965_device_info.c
@@ -361,7 +361,7 @@ static struct hw_codec_info skl_hw_codec_info = {
.has_hevc_encoding = 1,
.has_lp_h264_encoding = 1,
- .lp_h264_brc_mode = VA_RC_CQP,
+ .lp_h264_brc_mode = VA_RC_CQP | VA_RC_CBR | VA_RC_VBR,
.num_filters = 5,
.filters = {
</pre></blockquote><div><br></div></body></html>