<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 11.08.2016 19:47, Sean V Kelley
wrote:<br>
</div>
<blockquote cite="mid:1470934046.13352.3.camel@posteo.de"
type="cite">
<div class="-x-evo-paragraph -x-evo-top-signature-spacer">Hi Sree,</div>
<div><br>
</div>
<div><br>
</div>
<div>On Thu, 2016-08-11 at 14:55 +0300,
<a class="moz-txt-link-abbreviated" href="mailto:sreerenj.balachandran@intel.com">sreerenj.balachandran@intel.com</a> wrote:</div>
<blockquote type="cite">
<pre>From: Sreerenj Balachandran <<a moz-do-not-send="true" href="mailto:sreerenj.balachandran@intel.com">sreerenj.balachandran@intel.com</a>>
Low power encode through VDENC supports both CBR and VBR.
Make sure vaGetConfigAttribute correctly returns the supported
list of rate control modes in VAEntrypointEncSliceLP entrypoint.
</pre>
</blockquote>
<div><br>
</div>
<div>This was intentional. I'd prefer to delay this until we get
the GuC/HuC kernel patches merged. BRC depends on the HuC
firmware...</div>
</blockquote>
<br>
IIUC, HuC support is from BXT onwards, right?<br>
Which means no BRC for SKL VDENC ??<br>
<br>
<blockquote cite="mid:1470934046.13352.3.camel@posteo.de"
type="cite">
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://patchwork.freedesktop.org/series/9011/">https://patchwork.freedesktop.org/series/9011/</a></div>
<div><br>
</div>
<div>I'm also trying to get an interface (outside of debugfs) for
the driver to detect HuC FW loading</div>
<div>status in the revised/new patch set. We'll be reusing
I915_GETPARAM likely.</div>
<div><br>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Sean</div>
<div><br>
</div>
<blockquote type="cite">
<pre>---
src/i965_device_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/i965_device_info.c b/src/i965_device_info.c
index 47fd50a..a3a1027 100644
--- a/src/i965_device_info.c
+++ b/src/i965_device_info.c
@@ -361,7 +361,7 @@ static struct hw_codec_info skl_hw_codec_info = {
.has_hevc_encoding = 1,
.has_lp_h264_encoding = 1,
- .lp_h264_brc_mode = VA_RC_CQP,
+ .lp_h264_brc_mode = VA_RC_CQP | VA_RC_CBR | VA_RC_VBR,
.num_filters = 5,
.filters = {
</pre>
</blockquote>
<div><br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Thanks
Sree</pre>
<p>---------------------------------------------------------------------<br>
Intel Finland Oy<br>
Registered Address: PL 281, 00181 Helsinki <br>
Business Identity Code: 0357606 - 4 <br>
Domiciled in Helsinki </p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>