<div dir="ltr">Hi Daniel,<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 15, 2016 at 11:28 AM, Daniel Charles <span dir="ltr"><<a href="mailto:daniel.charles@intel.com" target="_blank">daniel.charles@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">after creating underlying surface there's a double check on the<br>
VAStatus result. Replace it with ASSERT_RET.<br>
<br>
Signed-off-by: Daniel Charles <<a href="mailto:daniel.charles@intel.com">daniel.charles@intel.com</a>><br>
---<br>
 src/i965_encoder.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/i965_encoder.c b/src/i965_encoder.c<br>
index beea811..d909846 100644<br>
--- a/src/i965_encoder.c<br>
+++ b/src/i965_encoder.c<br>
@@ -153,7 +153,7 @@ intel_encoder_check_yuv_<wbr>surface(VADriverContextP ctx,<br>
                                  VA_RT_FORMAT_YUV420,<br>
                                  1,<br>
                                  &encoder_context->input_yuv_<wbr>surface);<br>
-    assert(status == VA_STATUS_SUCCESS);<br>
+    ASSERT_RET(status == VA_STATUS_SUCCESS, status);<br>
<br>
     if (status != VA_STATUS_SUCCESS)<br>
         return status;<br></blockquote><div><br></div><div>You don't need this conditional with the ASSERT_RET().  Remove it too.</div><div><br></div><div>Thanks,</div><div><br></div><div>Sean</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888">--<br>
2.5.5<br>
<br>
______________________________<wbr>_________________<br>
Libva mailing list<br>
<a href="mailto:Libva@lists.freedesktop.org">Libva@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/libva" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/libva</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Sean V. Kelley <<a href="mailto:sean.v.kelley@intel.com" target="_blank">sean.v.kelley@intel.com</a>><br>Open Source Technology Center / SSG<br>Intel Corp.<br></div>
</div></div>