<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas",serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Yes, my apologies… I will be sure to add a cover from now on.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">FWIW…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">This patch series moves several of the auxiliary data input routines/classes for encode into the jpeg test data files in order to clean up the actual test implementation
file. Also move some of the common/generic test macros and functions to appropriate files. The JPEG::Encode::TestInput class was refactored to only allow it to be created with a shared_ptr. In addition, there is a typedef fix (not critical) and YUV format
conversion was moved to the class. YUV input initialization and conversion functions were also optimized a bit to avoid excessive intermediate copies. Finally, added support to cover YUY2, UYVY, and Y800 input formats in the JPEG encode tests.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Note that the Y800 test cases expose a decode bug in the driver for gen8+ and causes the test program to abort. The “jpeg/dec: gen8+ set correct fourcc for monochrome
decode” driver patch will fix this and is on the ML.<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:ZH-CN">U. Artie<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Sean V Kelley [mailto:seanvk@posteo.de]
<br>
<b>Sent:</b> Wednesday, September 28, 2016 1:48 PM<br>
<b>To:</b> Eoff, Ullysses A <ullysses.a.eoff@intel.com>; libva@lists.freedesktop.org<br>
<b>Subject:</b> Re: [Libva] [PATCH intel-driver 01/11] test: move ASSERT_NO_FAILURE macro to test.h<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">On Wed, 2016-09-28 at 13:36 -0700, U. Artie Eoff wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Both jpeg decode and encode test files use this macro.<o:p></o:p></pre>
<pre>So move it to the common test.h header to avoid duplicating<o:p></o:p></pre>
<pre>it.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
</blockquote>
<div>
<p class="MsoNormal">Please add brief cover in the future (patch 00/N) when you have a large series, even if they are mostly refactoring. I would like to see a concise summary for a large number of changes.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Sean<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Signed-off-by: U. Artie Eoff <<a href="mailto:ullysses.a.eoff@intel.com">ullysses.a.eoff@intel.com</a>><o:p></o:p></pre>
<pre>---<o:p></o:p></pre>
<pre> test/i965_jpeg_decode_test.cpp | 4 ----<o:p></o:p></pre>
<pre> test/i965_jpeg_encode_test.cpp | 4 ----<o:p></o:p></pre>
<pre> test/test.h | 4 ++++<o:p></o:p></pre>
<pre> 3 files changed, 4 insertions(+), 8 deletions(-)<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>diff --git a/test/i965_jpeg_decode_test.cpp b/test/i965_jpeg_decode_test.cpp<o:p></o:p></pre>
<pre>index b022c2e67c3e..6b8462564cfd 100644<o:p></o:p></pre>
<pre>--- a/test/i965_jpeg_decode_test.cpp<o:p></o:p></pre>
<pre>+++ b/test/i965_jpeg_decode_test.cpp<o:p></o:p></pre>
<pre>@@ -194,10 +194,6 @@ protected:<o:p></o:p></pre>
<pre> PictureData::SharedConst pd;<o:p></o:p></pre>
<pre> };<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>-#define ASSERT_NO_FAILURE(statement) \<o:p></o:p></pre>
<pre>- statement; \<o:p></o:p></pre>
<pre>- ASSERT_FALSE(HasFailure());<o:p></o:p></pre>
<pre>-<o:p></o:p></pre>
<pre> TEST_P(FourCCTest, Decode)<o:p></o:p></pre>
<pre> {<o:p></o:p></pre>
<pre> struct i965_driver_data *i965(*this);<o:p></o:p></pre>
<pre>diff --git a/test/i965_jpeg_encode_test.cpp b/test/i965_jpeg_encode_test.cpp<o:p></o:p></pre>
<pre>index 08d80c4f75b7..80ca1fdc62be 100644<o:p></o:p></pre>
<pre>--- a/test/i965_jpeg_encode_test.cpp<o:p></o:p></pre>
<pre>+++ b/test/i965_jpeg_encode_test.cpp<o:p></o:p></pre>
<pre>@@ -157,10 +157,6 @@ const TestInput::Shared NV12toI420(const TestInput::SharedConst& nv12)<o:p></o:p></pre>
<pre> return i420;<o:p></o:p></pre>
<pre> }<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>-#define ASSERT_NO_FAILURE(statement) \<o:p></o:p></pre>
<pre>- statement; \<o:p></o:p></pre>
<pre>- ASSERT_FALSE(HasFailure());<o:p></o:p></pre>
<pre>-<o:p></o:p></pre>
<pre> class JPEGEncodeInputTest<o:p></o:p></pre>
<pre> : public JPEGEncodeTest<o:p></o:p></pre>
<pre> , public ::testing::WithParamInterface<<o:p></o:p></pre>
<pre>diff --git a/test/test.h b/test/test.h<o:p></o:p></pre>
<pre>index afca9a5ed2d6..000284a2ca2e 100644<o:p></o:p></pre>
<pre>--- a/test/test.h<o:p></o:p></pre>
<pre>+++ b/test/test.h<o:p></o:p></pre>
<pre>@@ -66,6 +66,10 @@<o:p></o:p></pre>
<pre> #define ASSERT_PTR_NULL(ptr) \<o:p></o:p></pre>
<pre> ASSERT_TRUE(NULL == (ptr))<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>+#define ASSERT_NO_FAILURE(statement) \<o:p></o:p></pre>
<pre>+ statement; \<o:p></o:p></pre>
<pre>+ ASSERT_FALSE(HasFailure());<o:p></o:p></pre>
<pre>+<o:p></o:p></pre>
<pre> class VaapiStatus<o:p></o:p></pre>
<pre> {<o:p></o:p></pre>
<pre> public:<o:p></o:p></pre>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>