[LightDM] Merge "greeter-background" branch - revno: 295 [merge] - not quite

[poma]

On 01.06.2015 00:01, poma wrote:
> On 29.05.2015 06:28, poma wrote:
>> On 28.05.2015 20:23, Andrew P wrote:
>>> On Thu, May 28, 2015 at 8:51 PM, poma <pomidorabelisima at gmail.com> wrote:
>>>
>>>>
>>>> Guys, if any of you know how to x[11]trace lightdm-gtk-greeter?
>>>>
>>> https://bugs.freedesktop.org/show_bug.cgi?id=89730#c25
>>>
>>
>>
>> Thanks, now we know exactly how, here on Fedora:
>>
>> /usr/share/xgreeters/lightdm-gtk-greeter.desktop
>> [Desktop Entry]
>> Name=LightDM GTK+ Greeter
>> Comment=This runs the GTK+ greeter, it should only be run from LightDM
>> Exec=x11trace -D :11 -d :0 -b -o /var/log/lightdm/x11trace.log /sbin/lightdm-gtk-greeter
>> Type=Application
>>
>>
> 
> https://bugs.launchpad.net/ubuntu/+source/lightdm-gtk-greeter/+bug/1459079
> 
> Fleming can test whether the cloud should be loud, as here is.
> 
> Test compilation:
> http://goo.gl/Gm4ffO
> ISO/Fedora-Live-Xfce.iso
> 
> 


Loading background bitmap is solved with:

https://git.gnome.org/browse/gtk+/commit/?id=a34a022

$ git log --stat -1 -p gtk/gtkwindow.c
commit a34a0224e4fc6eff35fd41b7f318517b20b95713
Author: Jasper St. Pierre <jstpierre at mecheye.net>
Date:   Fri Feb 13 18:21:42 2015 -0800

    gtkwindow: Don't set the background if the window is app-paintable
    
    This fixes transparent DND windows.
---
 gtk/gtkwindow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gtk/gtkwindow.c b/gtk/gtkwindow.c
index 4dbde2a..2b1bcca 100644
--- a/gtk/gtkwindow.c
+++ b/gtk/gtkwindow.c
@@ -7006,7 +7006,7 @@ gtk_window_realize (GtkWidget *widget)
   /* We don't need to set a background on the GdkWindow; with decorations
    * we draw the background ourself
    */
-  if (!priv->client_decorated)
+  if (!priv->client_decorated && !gtk_widget_get_app_paintable (widget))
     gtk_style_context_set_background (gtk_widget_get_style_context (widget), gdk_window);
 
   attributes.x = allocation.x;


Backporting this particular commit(part of 3.15.7 release) to 3.14.x has no effect,
so rather than upgrade from:

gtk3-3.14.13-2.fc21
glib2-2.42.2-1.fc21
atk-2.14.0-1.fc21

to:

gtk3-3.15.7-1.fc21
glib2-2.43.4-1.fc21
atk-2.15.1-1.fc21

this would actually be the best solution:

gtk3-3.16.3-1.fc22
glib2-2.44.1-1.fc22
atk-2.16.0-1.fc22


I thank Ilia and Andrew for their participation.


Ref.
https://bugs.freedesktop.org/show_bug.cgi?id=89730
https://bugs.launchpad.net/ubuntu/+source/lightdm-gtk-greeter/+bug/1459079