[Lima] [PATCH v6 2/2] drm/lima: driver for ARM Mali4xx GPUs

Dave Airlie airlied at gmail.com
Wed Mar 6 04:13:08 UTC 2019


> >
> > I don't think you need the _pad fields here, and they're actually a bad
> > idea because the lack of checking in your ioctls means you can't trust
> > that userspace has initialized them to 0 when you want to redefine them
> > as a flags field later.
>
> Could I drop the _pad? I thought there is a rule that all drm ioctl arg size
> should be kept 64bit, is there?

Keep them but check in the driver that they are 0.

Dave.


More information about the lima mailing list