[Lima] [PATCH] drm: Return error codes from struct drm_driver.gem_create_object

[Thomas Zimmermann]

Hi

Am 07.12.21 um 10:24 schrieb Thomas Zimmermann:
> Hi
> 
> Am 07.12.21 um 09:55 schrieb Dan Carpenter:
>> I appologize.  This thread has been really frustrating.  I got mixed up
>> because I recently sent patches for ingenic and vc4.  Also we are
>> working against different trees so maybe that is part of the problem?
>>
>> I'm looking at today's linux-next.  Your patch has been applied.
>>
>> Yes.  You updated all the drivers.  But somehow the vc4 chunk from your
>> patch was dropped.  It was *NOT* dropped by Stephen Rothwell.  It got
>> dropped earlier.  I am including the `git format-patch -1 <hash>` output
>> from the commit.
> 
> My vc4 change is in drm-misc-next, [1] but not in drm-tip. [2] Your vc4 
> patch went through drm-misc-fixes.
> 
> drm-tip is build automatically by our DRM tools from the various trees. 
> The tools took my patch from drm-misc-next and your patch from 
> drm-misc-fixes and the result was broken.
> 
> Thanks for bringing this up. I'll see what I can do about it.

FYI I fixed drm-tip to return a pointer-encoded error in vc4. [1]

Best regards
Thomas

[1] 
https://cgit.freedesktop.org/drm/drm-tip/tree/drivers/gpu/drm/vc4/vc4_bo.c?id=cc3b9eb186e3c8dfb0bcc7d54fa4bfbe52c0b58b#n394


> 
> Best regards
> Thomas
> 
> [1] 
> https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/vc4/vc4_bo.c#n394 
> 
> [2] 
> https://cgit.freedesktop.org/drm/drm-tip/tree/drivers/gpu/drm/vc4/vc4_bo.c
> 
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/lima/attachments/20211208/233514ec/attachment.sig>