[Lima] [PATCH] lima: avoid error task dump attempt when not enabled
Javier Martinez Canillas
javierm at redhat.com
Wed Feb 9 09:26:48 UTC 2022
Hello Erico,
On 2/5/22 19:59, Erico Nunes wrote:
> Currently when users try to run an application with lima and that hits
> an issue such as a timeout, a message saying "fail to save task state"
> and "error task list is full" is shown in dmesg.
>
> The error task dump is a debug feature disabled by default, so the
> error task list is usually not going to be available at all.
> The message can be misleading and creates confusion in bug reports.
>
> We can avoid that code path and that particular message when the user
> has not explicitly set the max_error_tasks parameter to enable the
> feature.
>
> Signed-off-by: Erico Nunes <nunes.erico at gmail.com>
> ---
Looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
More information about the lima
mailing list