From jani.nikula at linux.intel.com Fri Jul 4 08:11:17 2025 From: jani.nikula at linux.intel.com (Jani Nikula) Date: Fri, 04 Jul 2025 11:11:17 +0300 Subject: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls In-Reply-To: <20250704075413.3218307-1-sakari.ailus@linux.intel.com> References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075413.3218307-1-sakari.ailus@linux.intel.com> Message-ID: On Fri, 04 Jul 2025, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus > --- > The cover letter of the set can be found here > . > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 I would think it's better to wait for linux-pm to get merged to Linus' tree and then backmerged to drm after -rc1 instead of cross-merging that directly to drm. Regardless, for merging the i915 changes via whichever tree, Acked-by: Jani Nikula -- Jani Nikula, Intel From laurent.pinchart at ideasonboard.com Fri Jul 4 08:58:48 2025 From: laurent.pinchart at ideasonboard.com (Laurent Pinchart) Date: Fri, 4 Jul 2025 11:58:48 +0300 Subject: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls In-Reply-To: <20250704075413.3218307-1-sakari.ailus@linux.intel.com> References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075413.3218307-1-sakari.ailus@linux.intel.com> Message-ID: <20250704085848.GD14736@pendragon.ideasonboard.com> Hi Sakari, Thank you for the patch. On Fri, Jul 04, 2025 at 10:54:13AM +0300, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus > --- > The cover letter of the set can be found here > . > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 -- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 -- > drivers/gpu/drm/bridge/parade-ps8640.c | 2 -- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 - > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ---- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 - > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 -- > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 1 - > drivers/gpu/drm/lima/lima_sched.c | 1 - > drivers/gpu/drm/panel/panel-edp.c | 3 --- > drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 -- > drivers/gpu/drm/panel/panel-simple.c | 2 -- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- > drivers/gpu/drm/tegra/submit.c | 1 - > drivers/gpu/drm/tidss/tidss_drv.c | 2 -- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 - > 20 files changed, 36 deletions(-) [snip] > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > index cf0d9049bcf1..bc5a94dba2d4 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > @@ -916,13 +916,11 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) > etnaviv_gpu_hw_init(gpu); > mutex_unlock(&gpu->lock); > > - pm_runtime_mark_last_busy(gpu->dev); > pm_runtime_put_autosuspend(gpu->dev); > > return 0; > > fail: You can drop the fail error later and replace it with pm_put. > - pm_runtime_mark_last_busy(gpu->dev); > pm_put: > pm_runtime_put_autosuspend(gpu->dev); > > @@ -1109,7 +1107,6 @@ int etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu, struct seq_file *m) > > ret = 0; > > - pm_runtime_mark_last_busy(gpu->dev); > pm_put: > pm_runtime_put_autosuspend(gpu->dev); > > @@ -1509,7 +1506,6 @@ void etnaviv_gpu_recover_hang(struct etnaviv_gem_submit *submit) > etnaviv_gpu_hw_init(gpu); > > mutex_unlock(&gpu->lock); > - pm_runtime_mark_last_busy(gpu->dev); > pm_put: > pm_runtime_put_autosuspend(gpu->dev); > } [snip] > diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c > index bb09df5000bd..11ec7e913974 100644 > --- a/drivers/gpu/drm/vc4/vc4_v3d.c > +++ b/drivers/gpu/drm/vc4/vc4_v3d.c > @@ -153,7 +153,6 @@ vc4_v3d_pm_put(struct vc4_dev *vc4) > > mutex_lock(&vc4->power_lock); > if (--vc4->power_refcount == 0) { > - pm_runtime_mark_last_busy(&vc4->v3d->pdev->dev); > pm_runtime_put_autosuspend(&vc4->v3d->pdev->dev); > } And here you can drop the curly braces. With that, Reviewed-by: Laurent Pinchart > mutex_unlock(&vc4->power_lock); -- Regards, Laurent Pinchart From thierry.reding at gmail.com Fri Jul 4 09:12:07 2025 From: thierry.reding at gmail.com (Thierry Reding) Date: Fri, 4 Jul 2025 11:12:07 +0200 Subject: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls In-Reply-To: <20250704075413.3218307-1-sakari.ailus@linux.intel.com> References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075413.3218307-1-sakari.ailus@linux.intel.com> Message-ID: On Fri, Jul 04, 2025 at 10:54:13AM +0300, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus [...] > diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c > index 2430fcc97448..5e0e76ebc5be 100644 > --- a/drivers/gpu/drm/tegra/submit.c > +++ b/drivers/gpu/drm/tegra/submit.c > @@ -502,7 +502,6 @@ static void release_job(struct host1x_job *job) > kfree(job_data->used_mappings); > kfree(job_data); > > - pm_runtime_mark_last_busy(client->base.dev); > pm_runtime_put_autosuspend(client->base.dev); > } > Acked-by: Thierry Reding -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From steven.price at arm.com Fri Jul 4 09:18:19 2025 From: steven.price at arm.com (Steven Price) Date: Fri, 4 Jul 2025 10:18:19 +0100 Subject: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls In-Reply-To: <20250704075413.3218307-1-sakari.ailus@linux.intel.com> References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075413.3218307-1-sakari.ailus@linux.intel.com> Message-ID: On 04/07/2025 08:54, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus > --- > The cover letter of the set can be found here > . > > In brief, this patch depends on PM runtime patches adding marking the last > busy timestamp in autosuspend related functions. The patches are here, on > rc2: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > pm-runtime-6.17-rc1 > > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 -- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 -- > drivers/gpu/drm/bridge/parade-ps8640.c | 2 -- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 - > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ---- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 -- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_scaler.c | 1 - > drivers/gpu/drm/i915/intel_runtime_pm.c | 2 -- > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 1 - > drivers/gpu/drm/lima/lima_sched.c | 1 - > drivers/gpu/drm/panel/panel-edp.c | 3 --- > drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 -- > drivers/gpu/drm/panel/panel-simple.c | 2 -- > drivers/gpu/drm/panthor/panthor_sched.c | 2 -- Panthor changes are: Reviewed-by: Steven Price Thanks, Steve > drivers/gpu/drm/tegra/submit.c | 1 - > drivers/gpu/drm/tidss/tidss_drv.c | 2 -- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 - > 20 files changed, 36 deletions(-) > [...] > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index a2248f692a03..f635f26a23f4 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -2446,7 +2446,6 @@ static void tick_work(struct work_struct *work) > > out_unlock: > mutex_unlock(&sched->lock); > - pm_runtime_mark_last_busy(ptdev->base.dev); > pm_runtime_put_autosuspend(ptdev->base.dev); > > out_dev_exit: > @@ -3203,7 +3202,6 @@ queue_run_job(struct drm_sched_job *sched_job) > > out_unlock: > mutex_unlock(&sched->lock); > - pm_runtime_mark_last_busy(ptdev->base.dev); > pm_runtime_put_autosuspend(ptdev->base.dev); > > return done_fence; From mcanal at igalia.com Fri Jul 4 10:24:46 2025 From: mcanal at igalia.com (=?UTF-8?Q?Ma=C3=ADra_Canal?=) Date: Fri, 4 Jul 2025 07:24:46 -0300 Subject: [PATCH 20/80] drivers: drm: Remove redundant pm_runtime_mark_last_busy() calls In-Reply-To: <20250704075413.3218307-1-sakari.ailus@linux.intel.com> References: <20250704075225.3212486-1-sakari.ailus@linux.intel.com> <20250704075413.3218307-1-sakari.ailus@linux.intel.com> Message-ID: <68b4d53f-a185-4e11-af1e-532fc45cb8b2@igalia.com> Hi Sakari, On 04/07/25 04:54, Sakari Ailus wrote: > pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), > pm_runtime_autosuspend() and pm_request_autosuspend() now include a call > to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to > pm_runtime_mark_last_busy(). > > Signed-off-by: Sakari Ailus > --- [...] > diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c > index bb09df5000bd..11ec7e913974 100644 > --- a/drivers/gpu/drm/vc4/vc4_v3d.c > +++ b/drivers/gpu/drm/vc4/vc4_v3d.c > @@ -153,7 +153,6 @@ vc4_v3d_pm_put(struct vc4_dev *vc4) > > mutex_lock(&vc4->power_lock); > if (--vc4->power_refcount == 0) { > - pm_runtime_mark_last_busy(&vc4->v3d->pdev->dev); > pm_runtime_put_autosuspend(&vc4->v3d->pdev->dev); > } Nit: please, drop the curly braces. > mutex_unlock(&vc4->power_lock); For vc4, Reviewed-by: Ma?ra Canal Best Regards, - Ma?ra