[Mesa-ci-intel] Update piglit branch for 18.2 branch (including staging branches)

Juan A. Suarez Romero jasuarez at igalia.com
Tue Nov 20 09:22:25 UTC 2018


On Mon, 2018-11-19 at 14:58 -0800, Mark Janes wrote:
> "Juan A. Suarez Romero" <jasuarez at igalia.com> writes:
> 
> > Hi.
> > 
> > Mesa commit e0837f061a6 ("egl/dri: fix error value with unknown drm format")
> > fixes returned with an unknown drm format.
> > 
> > This was fixed in piglit too, in commit c79d8d223
> > ("EGL_EXT_image_dma_buf_import: fix error check with unknown drm format").
> > 
> > 
> > The Mesa commit has been cherry-picked for 18.2, but the piglit branch used as
> > reference does not have the piglit fix.
> > 
> > Hence, we need to update the piglit branch to that commit or newer, to avoid
> > errors.
> 
> We don't change the test suites that are used for stable branches unless
> we are forced to.  Instead, I've updated the CI config files to note
> where the piglit test was fixed.  Since the stable branches test an
> older piglit, the status will be filtered.
> 


Right! I had forgotten you can mark the expected results for tests. That works
for me.


Thanks.

>  https://gitlab.freedesktop.org/Mesa_CI/mesa_jenkins/commit/9217444f98d9c39590809e6bd2c264cf8a0463f2
> 
> Ideally, changes to piglit tests would be pushed well ahead of the
> corresponding Mesa patches.  A test-first ordering of the work would
> make the CI aware of the status changes.
> 
> > Maybe this need to be done also for other branches.
> > 
> > 
> > Thanks in advance!
> > 
> > 
> > 	J.a
> > 
> > _______________________________________________
> > Mesa-ci-intel mailing list
> > Mesa-ci-intel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-ci-intel



More information about the Mesa-ci-intel mailing list