Mesa (master): i965: Update state before checking for fallbacks in brw_try_draw_prims.

Eric Anholt anholt at kemper.freedesktop.org
Mon Dec 15 21:34:36 UTC 2008


Module: Mesa
Branch: master
Commit: 095c3a5cb16dae5c1e4cf85bffd3cb2465ab9e28
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=095c3a5cb16dae5c1e4cf85bffd3cb2465ab9e28

Author: Eric Anholt <eric at anholt.net>
Date:   Mon Dec 15 13:25:20 2008 -0800

i965: Update state before checking for fallbacks in brw_try_draw_prims.

This got flipped around in 7855b2aef6bd9e9c2d73260b5cd166159b2525c6.

Bug #18907.  Thanks to idr for pointing me at a nicer testcase than blender.

---

 src/mesa/drivers/dri/i965/brw_draw.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index c3a26fc..785fb78 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -309,12 +309,12 @@ static GLboolean brw_try_draw_prims( GLcontext *ctx,
       if (first_time || (brw->state.dirty.brw & BRW_NEW_PRIMITIVE)) {
 	 first_time = GL_FALSE;
 
+	 brw_validate_state(brw);
+
 	 /* Various fallback checks:  */
 	 if (brw->intel.Fallback)
 	    goto out;
 
-	 brw_validate_state(brw);
-
 	 /* Check that we can fit our state in with our existing batchbuffer, or
 	  * flush otherwise.
 	  */




More information about the mesa-commit mailing list