Mesa (mesa_7_5_branch): intel: Fix inverted test for disabling flushing of front buffer output.

Brian Paul brianp at kemper.freedesktop.org
Tue Aug 4 15:28:00 UTC 2009


Module: Mesa
Branch: mesa_7_5_branch
Commit: 61673aebb0c92bf187189c496e6c3a856825eceb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=61673aebb0c92bf187189c496e6c3a856825eceb

Author: Brian Paul <brianp at vmware.com>
Date:   Tue Aug  4 09:23:17 2009 -0600

intel: Fix inverted test for disabling flushing of front buffer output.

The comment disagreed with the code, and nicely drew my eyes to what was
going wrong.

Bug #21774 (blender)
Bug #21788 (readpix)

(cherry picked from master, commit fd65418f600874b05f902b622078b40bc1abb24a)

---

 src/mesa/drivers/dri/intel/intel_context.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
index a40951a..50ae677 100644
--- a/src/mesa/drivers/dri/intel/intel_context.c
+++ b/src/mesa/drivers/dri/intel/intel_context.c
@@ -505,7 +505,7 @@ intel_flush(GLcontext *ctx, GLboolean needs_mi_flush)
 	  * each of N places that do rendering.  This has worse performances,
 	  * but it is much easier to get correct.
 	  */
-	 if (intel->is_front_buffer_rendering) {
+	 if (!intel->is_front_buffer_rendering) {
 	    intel->front_buffer_dirty = GL_FALSE;
 	 }
       }




More information about the mesa-commit mailing list