Mesa (master): llvmpipe: plug in dummy pipe_context:: set_vertex_sampler_textures function

Brian Paul brianp at vmware.com
Wed Dec 2 11:17:49 PST 2009


michal wrote:
> Brian Paul pisze:
>> Module: Mesa
>> Branch: master
>> Commit: 792888121b92913733daec7526c9441f27ce1231
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=792888121b92913733daec7526c9441f27ce1231
>>
>> Author: Brian Paul <brianp at vmware.com>
>> Date:   Wed Dec  2 10:09:53 2009 -0700
>>
>> llvmpipe: plug in dummy pipe_context::set_vertex_sampler_textures function
>>
>> Fixes immediate segfault.
>>
>>   
> Is the segfault happening in llvmpipe or in mesa state tracker? A state 
> tracker should not touch those new entrypoints if the driver reports 0 
> for NUM_VERTEX_TEXTURE_UNITS.


#0  0x00000000 in ?? ()
#1  0x009a8080 in cso_set_vertex_sampler_textures (ctx=0x8150410, 
count=0,
     textures=0x8120778) at cso_context.c:622
#2  0x00933200 in update_textures (st=0x81203f0)
     at state_tracker/st_atom_texture.c:105
#3  0x0092d940 in st_validate_state (st=0x81203f0)
     at state_tracker/st_atom.c:165
#4  0x00938da6 in st_clear (ctx=0x80e1c58, mask=2)
     at state_tracker/st_cb_clear.c:431
#5  0x008ae1af in _mesa_Clear (mask=16384) at main/clear.c:182
#6  0x0079e39f in glClear (mask=16384) at 
../../src/mesa/glapi/glapitemp.h:1100
#7  0x08048ca9 in Draw () at tri.c:73
#8  0x001238f6 in processWindowWorkList (window=0x8058340) at 
glut_event.c:1306
#9  0x001239eb in __glutProcessWindowWorkLists () at glut_event.c:1356
#10 0x00123a60 in glutMainLoop () at glut_event.c:1377
#11 0x08048f7c in main (argc=1, argv=0xbffff404) at tri.c:134


Looks like we shouldn't be returning 16 for the 
PIPE_CAP_MAX_VERTEX_TEXTURE_UNITS query in lp_screen.c

I'll revert this commit and fix the PIPE_CAP_MAX_VERTEX_TEXTURE_UNITS 
query.

-Brian


More information about the mesa-commit mailing list