Mesa (master): Revert "r300g: flush CS if a buffer being deleted is referenced by it"

Corbin Simpson csimpson at kemper.freedesktop.org
Fri Dec 18 02:56:11 PST 2009


Module: Mesa
Branch: master
Commit: a70eba5648b114e13d48b79dc38705b2fc2a8e95
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a70eba5648b114e13d48b79dc38705b2fc2a8e95

Author: Corbin Simpson <MostAwesomeDude at gmail.com>
Date:   Fri Dec 18 02:55:28 2009 -0800

Revert "r300g: flush CS if a buffer being deleted is referenced by it"

As requested by just about everybody. I'm going back to actually reading
patches before ACKing and pushing them.

This reverts commit 417ce06306962a9355cbb35cefcdea1951b0ce85.

Conflicts:

	src/gallium/winsys/drm/radeon/core/radeon_buffer.c

---

 src/gallium/winsys/drm/radeon/core/radeon_buffer.c |    6 ------
 src/gallium/winsys/drm/radeon/core/radeon_buffer.h |    1 -
 src/gallium/winsys/drm/radeon/core/radeon_drm.c    |    1 -
 3 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/gallium/winsys/drm/radeon/core/radeon_buffer.c b/src/gallium/winsys/drm/radeon/core/radeon_buffer.c
index b8be059..d2367b2 100644
--- a/src/gallium/winsys/drm/radeon/core/radeon_buffer.c
+++ b/src/gallium/winsys/drm/radeon/core/radeon_buffer.c
@@ -82,7 +82,6 @@ static struct pipe_buffer *radeon_buffer_create(struct pipe_winsys *ws,
         domain |= RADEON_GEM_DOMAIN_GTT;
     }
 
-    radeon_buffer->ws = radeon_ws;
     radeon_buffer->bo = radeon_bo_open(radeon_ws->priv->bom, 0, size,
             alignment, domain, 0);
     if (radeon_buffer->bo == NULL) {
@@ -133,11 +132,6 @@ static void radeon_buffer_del(struct pipe_buffer *buffer)
 {
     struct radeon_pipe_buffer *radeon_buffer =
         (struct radeon_pipe_buffer*)buffer;
-    struct radeon_winsys_priv *priv = radeon_buffer->ws->priv;
-
-    if (radeon_bo_is_referenced_by_cs(radeon_buffer->bo, priv->cs)) {
-        priv->flush_cb(priv->flush_data);
-    }
 
     radeon_bo_unref(radeon_buffer->bo);
     free(radeon_buffer);
diff --git a/src/gallium/winsys/drm/radeon/core/radeon_buffer.h b/src/gallium/winsys/drm/radeon/core/radeon_buffer.h
index 950a1d6..d7f1756 100644
--- a/src/gallium/winsys/drm/radeon/core/radeon_buffer.h
+++ b/src/gallium/winsys/drm/radeon/core/radeon_buffer.h
@@ -50,7 +50,6 @@
 struct radeon_pipe_buffer {
     struct pipe_buffer  base;
     struct radeon_bo    *bo;
-    struct radeon_winsys *ws;
     boolean flinked;
     uint32_t flink;
 };
diff --git a/src/gallium/winsys/drm/radeon/core/radeon_drm.c b/src/gallium/winsys/drm/radeon/core/radeon_drm.c
index 2f7fbc7..dec7c06 100644
--- a/src/gallium/winsys/drm/radeon/core/radeon_drm.c
+++ b/src/gallium/winsys/drm/radeon/core/radeon_drm.c
@@ -171,7 +171,6 @@ struct pipe_buffer* radeon_buffer_from_handle(struct drm_api* api,
     radeon_buffer->base.screen = screen;
     radeon_buffer->base.usage = PIPE_BUFFER_USAGE_PIXEL;
     radeon_buffer->bo = bo;
-    radeon_buffer->ws = (struct radeon_winsys*)screen->winsys;
     return &radeon_buffer->base;
 }
 



More information about the mesa-commit mailing list